Remove redundant argument from onChange (#2852)

Author: charisk

extensions/ql-vscode/src/stories/method-modeling/MethodModelingInputs.stories.tsx

@@ -7,7 +7,6 @@ import { createMethod } from "../../../test/factories/model-editor/method-factor
 import { createModeledMethod } from "../../../test/factories/model-editor/modeled-method-factories";
 import { useState } from "react";
 import { ModeledMethod } from "../../model-editor/modeled-method";
-import { Method } from "../../model-editor/method";
 
 export default {
   title: "Method Modeling/Method Modeling Inputs",
@@ -26,7 +25,7 @@ const Template: StoryFn<typeof MethodModelingInputsComponent> = (args) => {
     args.modeledMethod,
   );
 
-  const onChange = (method: Method, modeledMethod: ModeledMethod) => {
+  const onChange = (modeledMethod: ModeledMethod) => {
     setModeledMethod(modeledMethod);
   };
 

extensions/ql-vscode/src/view/method-modeling/MethodModeling.tsx

@@ -36,7 +36,7 @@ export type MethodModelingProps = {
   modelingStatus: ModelingStatus;
   method: Method;
   modeledMethod: ModeledMethod | undefined;
-  onChange: (method: Method, modeledMethod: ModeledMethod) => void;
+  onChange: (modeledMethod: ModeledMethod) => void;
 };
 
 export const MethodModeling = ({

extensions/ql-vscode/src/view/method-modeling/MethodModelingInputs.tsx

@@ -21,7 +21,7 @@ const Name = styled.span`
 export type MethodModelingInputsProps = {
   method: Method;
   modeledMethod: ModeledMethod | undefined;
-  onChange: (method: Method, modeledMethod: ModeledMethod) => void;
+  onChange: (modeledMethod: ModeledMethod) => void;
 };
 
 export const MethodModelingInputs = ({

extensions/ql-vscode/src/view/method-modeling/MethodModelingView.tsx

@@ -44,7 +44,7 @@ export function MethodModelingView(): JSX.Element {
 
   // For now we just store the updated method in the state but soon
   // we'll need to send it back to the other views.
-  const onChange = (method: Method, modeledMethod: ModeledMethod) => {
+  const onChange = (modeledMethod: ModeledMethod) => {
     setModeledMethod(modeledMethod);
   };
 

extensions/ql-vscode/src/view/method-modeling/__tests__/MethodModelingInputs.spec.tsx

@@ -54,7 +54,6 @@ describe(MethodModelingInputs.name, () => {
     await userEvent.selectOptions(modelTypeDropdown, "source");
 
     expect(onChange).toHaveBeenCalledWith(
-      method,
       expect.objectContaining({
         type: "source",
       }),

extensions/ql-vscode/src/view/model-editor/LibraryRow.tsx

@@ -76,7 +76,7 @@ export type LibraryRowProps = {
   inProgressMethods: InProgressMethods;
   viewState: ModelEditorViewState;
   hideModeledMethods: boolean;
-  onChange: (method: Method, modeledMethod: ModeledMethod) => void;
+  onChange: (modeledMethod: ModeledMethod) => void;
   onSaveModelClick: (
     methods: Method[],
     modeledMethods: Record<string, ModeledMethod>,

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

@@ -56,7 +56,7 @@ export type MethodRowProps = {
   methodIsUnsaved: boolean;
   modelingInProgress: boolean;
   mode: Mode;
-  onChange: (method: Method, modeledMethod: ModeledMethod) => void;
+  onChange: (modeledMethod: ModeledMethod) => void;
 };
 
 export const MethodRow = (props: MethodRowProps) => {

extensions/ql-vscode/src/view/model-editor/ModelEditor.tsx

@@ -179,14 +179,14 @@ export function ModelEditor({
     [methods],
   );
 
-  const onChange = useCallback((method: Method, model: ModeledMethod) => {
+  const onChange = useCallback((model: ModeledMethod) => {
     setModeledMethods((oldModeledMethods) => ({
       ...oldModeledMethods,
-      [method.signature]: model,
+      [model.signature]: model,
     }));
     setModifiedSignatures(
       (oldModifiedSignatures) =>
-        new Set([...oldModifiedSignatures, method.signature]),
+        new Set([...oldModifiedSignatures, model.signature]),
     );
   }, []);
 

extensions/ql-vscode/src/view/model-editor/ModelInputDropdown.tsx

@@ -7,7 +7,7 @@ import { Method, getArgumentsList } from "../../model-editor/method";
 type Props = {
   method: Method;
   modeledMethod: ModeledMethod | undefined;
-  onChange: (method: Method, modeledMethod: ModeledMethod) => void;
+  onChange: (modeledMethod: ModeledMethod) => void;
 };
 
 export const ModelInputDropdown = ({
@@ -45,12 +45,12 @@ export const ModelInputDropdown = ({
 
       const target = e.target as HTMLSelectElement;
 
-      onChange(method, {
+      onChange({
         ...modeledMethod,
         input: target.value,
       });
     },
-    [onChange, method, modeledMethod],
+    [onChange, modeledMethod],
   );
 
   return (

extensions/ql-vscode/src/view/model-editor/ModelKindDropdown.tsx

@@ -11,7 +11,7 @@ import { extensiblePredicateDefinitions } from "../../model-editor/predicates";
 type Props = {
   method: Method;
   modeledMethod: ModeledMethod | undefined;
-  onChange: (method: Method, modeledMethod: ModeledMethod) => void;
+  onChange: (modeledMethod: ModeledMethod) => void;
 };
 
 export const ModelKindDropdown = ({
@@ -43,12 +43,12 @@ export const ModelKindDropdown = ({
         return;
       }
 
-      onChange(method, {
+      onChange({
         ...modeledMethod,
         kind,
       });
     },
-    [method, modeledMethod, onChange],
+    [modeledMethod, onChange],
   );
 
   const handleChange = useCallback(