Skip to content

Commit 3b8cea8

Browse files
Remove codeQL.copyVariantAnalysisRepoListQueryHistory command and instead call copyRepoListToClipboard directly
1 parent f05d5d9 commit 3b8cea8

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

extensions/ql-vscode/src/common/commands.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,6 @@ export type VariantAnalysisCommands = {
244244
scannedRepo: VariantAnalysisScannedRepository,
245245
variantAnalysisSummary: VariantAnalysis,
246246
) => Promise<void>;
247-
"codeQL.copyVariantAnalysisRepoListQueryHistory": (
248-
variantAnalysisId: number,
249-
filterSort?: RepositoriesFilterSortStateWithIds,
250-
) => Promise<void>;
251247
"codeQL.copyVariantAnalysisRepoListView": (
252248
variantAnalysisId: number,
253249
filterSort?: RepositoriesFilterSortStateWithIds,

extensions/ql-vscode/src/query-history/query-history-manager.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -952,8 +952,7 @@ export class QueryHistoryManager extends DisposableObject {
952952
return;
953953
}
954954

955-
await this.app.commands.execute(
956-
"codeQL.copyVariantAnalysisRepoListQueryHistory",
955+
await this.variantAnalysisManager.copyRepoListToClipboard(
957956
item.variantAnalysis.id,
958957
);
959958
}

extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,6 @@ export class VariantAnalysisManager
148148
return {
149149
"codeQL.autoDownloadVariantAnalysisResult":
150150
this.enqueueDownload.bind(this),
151-
"codeQL.copyVariantAnalysisRepoListQueryHistory":
152-
this.copyRepoListToClipboard.bind(this),
153151
"codeQL.copyVariantAnalysisRepoListView":
154152
this.copyRepoListToClipboard.bind(this),
155153
"codeQL.loadVariantAnalysisRepoResults": this.loadResults.bind(this),

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/query-history-manager.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -710,11 +710,12 @@ describe("QueryHistoryManager", () => {
710710

711711
it("should copy repo list for a single variant analysis", async () => {
712712
queryHistoryManager = await createMockQueryHistory(allHistory);
713+
queryHistoryManager.handleCopyRepoList = jest.fn();
713714

714715
const item = variantAnalysisHistory[1];
715716
await queryHistoryManager.handleCopyRepoList(item);
716-
expect(executeCommand).toBeCalledWith(
717-
"codeQL.copyVariantAnalysisRepoListQueryHistory",
717+
718+
expect(queryHistoryManager.handleCopyRepoList).toBeCalledWith(
718719
item.variantAnalysis.id,
719720
);
720721
});

0 commit comments

Comments
 (0)