Remove codeQL.dataExtensions.frameworkMode setting (#2753)

Author: charisk

extensions/ql-vscode/src/config.ts

@@ -704,7 +704,6 @@ export function showQueriesPanel(): boolean {
 
 const DATA_EXTENSIONS = new Setting("dataExtensions", ROOT_SETTING);
 const LLM_GENERATION = new Setting("llmGeneration", DATA_EXTENSIONS);
-const FRAMEWORK_MODE = new Setting("frameworkMode", DATA_EXTENSIONS);
 const DISABLE_AUTO_NAME_EXTENSION_PACK = new Setting(
   "disableAutoNameExtensionPack",
   DATA_EXTENSIONS,
@@ -718,10 +717,6 @@ export function showLlmGeneration(): boolean {
   return !!LLM_GENERATION.getValue<boolean>();
 }
 
-export function enableFrameworkMode(): boolean {
-  return !!FRAMEWORK_MODE.getValue<boolean>();
-}
-
 export function disableAutoNameExtensionPack(): boolean {
   return !!DISABLE_AUTO_NAME_EXTENSION_PACK.getValue<boolean>();
 }

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

@@ -31,7 +31,7 @@ import { runExternalApiQueries } from "./external-api-usage-queries";
 import { ExternalApiUsage, Usage } from "./external-api-usage";
 import { ModeledMethod } from "./modeled-method";
 import { ExtensionPack } from "./shared/extension-pack";
-import { enableFrameworkMode, showLlmGeneration } from "../config";
+import { showLlmGeneration } from "../config";
 import { Mode } from "./shared/mode";
 import { loadModeledMethods, saveModeledMethods } from "./modeled-method-fs";
 import { join } from "path";
@@ -267,7 +267,6 @@ export class DataExtensionsEditorView extends AbstractWebview<
       t: "setDataExtensionEditorViewState",
       viewState: {
         extensionPack: this.extensionPack,
-        enableFrameworkMode: enableFrameworkMode(),
         showLlmButton,
         mode: this.mode,
       },

extensions/ql-vscode/src/data-extensions-editor/shared/view-state.ts

@@ -3,7 +3,6 @@ import { Mode } from "./mode";
 
 export interface DataExtensionEditorViewState {
   extensionPack: ExtensionPack;
-  enableFrameworkMode: boolean;
   showLlmButton: boolean;
   mode: Mode;
 }

extensions/ql-vscode/src/stories/data-extensions-editor/DataExtensionsEditor.stories.tsx

@@ -28,7 +28,6 @@ DataExtensionsEditor.args = {
       extensionTargets: {},
       dataExtensions: [],
     },
-    enableFrameworkMode: true,
     showLlmButton: true,
     mode: Mode.Application,
   },

extensions/ql-vscode/src/view/data-extensions-editor/DataExtensionsEditor.tsx

@@ -320,14 +320,12 @@ export function DataExtensionsEditor({
               <span slot="start" className="codicon codicon-package"></span>
               Open extension pack
             </LinkIconButton>
-            {viewState.enableFrameworkMode && (
-              <LinkIconButton onClick={onSwitchModeClick}>
-                <span slot="start" className="codicon codicon-library"></span>
-                {viewState.mode === Mode.Framework
-                  ? "Model as application"
-                  : "Model as dependency"}
-              </LinkIconButton>
-            )}
+            <LinkIconButton onClick={onSwitchModeClick}>
+              <span slot="start" className="codicon codicon-library"></span>
+              {viewState.mode === Mode.Framework
+                ? "Model as application"
+                : "Model as dependency"}
+            </LinkIconButton>
           </HeaderRow>
         </HeaderColumn>
         <HeaderSpacer />
@@ -349,11 +347,9 @@ export function DataExtensionsEditor({
           >
             Save all
           </VSCodeButton>
-          {viewState.enableFrameworkMode && (
-            <VSCodeButton appearance="secondary" onClick={onRefreshClick}>
-              Refresh
-            </VSCodeButton>
-          )}
+          <VSCodeButton appearance="secondary" onClick={onRefreshClick}>
+            Refresh
+          </VSCodeButton>
           {viewState.mode === Mode.Framework && (
             <VSCodeButton onClick={onGenerateFromSourceClick}>
               Generate

extensions/ql-vscode/src/view/data-extensions-editor/LibraryRow.tsx

@@ -221,13 +221,12 @@ export const LibraryRow = ({
              Model from source
           </VSCodeButton>
         )}
-        {viewState.enableFrameworkMode &&
-          viewState.mode === Mode.Application && (
-            <VSCodeButton appearance="icon" onClick={handleModelDependency}>
-              <Codicon name="references" label="Model dependency" />
-              &nbsp;Model dependency
-            </VSCodeButton>
-          )}
+        {viewState.mode === Mode.Application && (
+          <VSCodeButton appearance="icon" onClick={handleModelDependency}>
+            <Codicon name="references" label="Model dependency" />
+            &nbsp;Model dependency
+          </VSCodeButton>
+        )}
       </TitleContainer>
       {isExpanded && (
         <>