Add pre-push hook check to block leftover .only()s (#1189)

charisk · web-flow · commit 3fc3b259ba2f · 2022-03-08T09:32:18.000Z
diff --git a/extensions/ql-vscode/package.json b/extensions/ql-vscode/package.json
@@ -1170,7 +1170,7 @@
   "husky": {
     "hooks": {
       "pre-commit": "npm run format-staged",
-      "pre-push": "npm run lint"
+      "pre-push": "npm run lint && scripts/forbid-mocha-only"
     }
   },
   "lint-staged": {
diff --git a/extensions/ql-vscode/scripts/forbid-mocha-only b/extensions/ql-vscode/scripts/forbid-mocha-only
@@ -0,0 +1,6 @@
+if grep -rq --include '*.test.ts' 'it.only\|describe.only' './test' './src'; then
+    echo 'There is a .only() in the tests. Please remove it.'
+    exit 1;
+else
+    exit 0;
+fi

Original file line number	Diff line number	Diff line change
`@@ -1170,7 +1170,7 @@`
`1170`	`1170`	`"husky": {`
`1171`	`1171`	`"hooks": {`
`1172`	`1172`	`"pre-commit": "npm run format-staged",`
`1173`		`- "pre-push": "npm run lint"`
	`1173`	`+ "pre-push": "npm run lint && scripts/forbid-mocha-only"`
`1174`	`1174`	`}`
`1175`	`1175`	`},`
`1176`	`1176`	`"lint-staged": {`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,6 @@ @@
 +if grep -rq --include '*.test.ts' 'it.only\|describe.only' './test' './src'; then
 +    echo 'There is a .only() in the tests. Please remove it.'
 +    exit 1;
 +else
 +    exit 0;
 +fi