Skip to content

Commit 41f4e04

Browse files
committed
Create custom log directory, if possible
(I haven't got the error handling to work asynchronously, so I stuck with `mkdirSync` for now)
1 parent 7e27f20 commit 41f4e04

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

extensions/ql-vscode/src/queryserver-client.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,12 @@ export class QueryServerClient extends DisposableObject {
9393
let storagePath = this.opts.contextStoragePath;
9494
let isCustomLogDirectory = false;
9595
if (this.config.customLogDirectory) {
96-
if (fs.existsSync(this.config.customLogDirectory) && fs.statSync(this.config.customLogDirectory).isDirectory()) {
96+
try {
97+
fs.mkdirSync(this.config.customLogDirectory);
98+
helpers.showAndLogInformationMessage(`Storing query server logs to user-specified directory: ${this.config.customLogDirectory}.`);
9799
storagePath = this.config.customLogDirectory;
98100
isCustomLogDirectory = true;
99-
} else if (this.config.customLogDirectory) {
101+
} catch (e) {
100102
helpers.showAndLogErrorMessage(`${this.config.customLogDirectory} is not a valid directory. Logs will be stored in a temporary workspace directory instead.`);
101103
}
102104
}

0 commit comments

Comments
 (0)