Skip to content

Commit 429f9a1

Browse files
authored
Sort databases by name if their languages are the same (#3055)
1 parent 1c19d7a commit 429f9a1

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

extensions/ql-vscode/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## [UNRELEASED]
44

5+
- The "Sort by Language" action in the databases view now sorts by name within each language. [#3055](https://github.com/github/vscode-codeql/pull/3055)
6+
57
## 1.9.4 - 6 November 2023
68

79
No user facing changes.

extensions/ql-vscode/src/databases/local-databases-ui.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,17 @@ class DatabaseTreeDataProvider
158158
case SortOrder.NameDesc:
159159
return db2.name.localeCompare(db1.name, env.language);
160160
case SortOrder.LanguageAsc:
161-
return db1.language.localeCompare(db2.language, env.language);
161+
return (
162+
db1.language.localeCompare(db2.language, env.language) ||
163+
// If the languages are the same, sort by name
164+
db1.name.localeCompare(db2.name, env.language)
165+
);
162166
case SortOrder.LanguageDesc:
163-
return db2.language.localeCompare(db1.language, env.language);
167+
return (
168+
db2.language.localeCompare(db1.language, env.language) ||
169+
// If the languages are the same, sort by name
170+
db2.name.localeCompare(db1.name, env.language)
171+
);
164172
case SortOrder.DateAddedAsc:
165173
return (db1.dateAdded || 0) - (db2.dateAdded || 0);
166174
case SortOrder.DateAddedDesc:

0 commit comments

Comments
 (0)