Skip to content

Commit 43bcd69

Browse files
committed
Use proper casing for alert type text
1 parent 53a17d5 commit 43bcd69

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

extensions/ql-vscode/src/view/common/Alert.tsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,15 @@ const getBorderColor = ({ type }: ContainerProps): string => {
4242
}
4343
};
4444

45+
const getTypeText = (type: ContainerProps['type']): string => {
46+
switch (type) {
47+
case 'warning':
48+
return 'Warning';
49+
case 'error':
50+
return 'Error';
51+
}
52+
};
53+
4554
const Container = styled.div<ContainerProps>`
4655
display: flex;
4756
flex-direction: column;
@@ -81,7 +90,7 @@ type Props = {
8190
export const Alert = ({ type, title, message, actions, inverse }: Props) => {
8291
return (
8392
<Container type={type} inverse={inverse}>
84-
<Title>{type}: {title}</Title>
93+
<Title>{getTypeText(type)}: {title}</Title>
8594
<span>{message}</span>
8695
{actions && <ActionsContainer>{actions}</ActionsContainer>}
8796
</Container>

extensions/ql-vscode/src/view/common/__tests__/Alert.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ describe(Alert.name, () => {
66
it('renders a warning correctly', () => {
77
render(<Alert type="warning" title="Warning title" message="Warning content" />);
88

9-
expect(screen.getByText('warning: Warning title')).toBeInTheDocument();
9+
expect(screen.getByText('Warning: Warning title')).toBeInTheDocument();
1010
expect(screen.getByText('Warning content')).toBeInTheDocument();
1111
});
1212

1313
it('renders an error correctly', () => {
1414
render(<Alert type="error" title="Error title" message="Error content" />);
1515

16-
expect(screen.getByText('error: Error title')).toBeInTheDocument();
16+
expect(screen.getByText('Error: Error title')).toBeInTheDocument();
1717
expect(screen.getByText('Error content')).toBeInTheDocument();
1818
});
1919

0 commit comments

Comments
 (0)