Skip to content

Commit 43c0d15

Browse files
Convert handleShowEvalLogSummary to use createSingleSelectionCommand
1 parent ccd73b2 commit 43c0d15

1 file changed

Lines changed: 8 additions & 16 deletions

File tree

extensions/ql-vscode/src/query-history/query-history-manager.ts

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,10 @@ export class QueryHistoryManager extends DisposableObject {
256256
this.handleShowEvalLog.bind(this),
257257
"query",
258258
),
259-
"codeQLQueryHistory.showEvalLogSummary":
259+
"codeQLQueryHistory.showEvalLogSummary": createSingleSelectionCommand(
260260
this.handleShowEvalLogSummary.bind(this),
261+
"query",
262+
),
261263
"codeQLQueryHistory.showEvalLogViewer":
262264
this.handleShowEvalLogViewer.bind(this),
263265
"codeQLQueryHistory.showQueryLog": createSingleSelectionCommand(
@@ -740,28 +742,18 @@ export class QueryHistoryManager extends DisposableObject {
740742
}
741743
}
742744

743-
async handleShowEvalLogSummary(
744-
singleItem: QueryHistoryInfo,
745-
multiSelect: QueryHistoryInfo[] | undefined,
746-
) {
747-
// Only applicable to an individual local query
748-
if (!this.assertSingleQuery(multiSelect) || singleItem.t !== "local") {
745+
async handleShowEvalLogSummary(item: QueryHistoryInfo) {
746+
if (item.t !== "local") {
749747
return;
750748
}
751749

752-
if (singleItem.evalLogSummaryLocation) {
753-
await tryOpenExternalFile(
754-
this.app.commands,
755-
singleItem.evalLogSummaryLocation,
756-
);
750+
if (item.evalLogSummaryLocation) {
751+
await tryOpenExternalFile(this.app.commands, item.evalLogSummaryLocation);
757752
return;
758753
}
759754

760755
// Summary log file doesn't exist.
761-
if (
762-
singleItem.evalLogLocation &&
763-
(await pathExists(singleItem.evalLogLocation))
764-
) {
756+
if (item.evalLogLocation && (await pathExists(item.evalLogLocation))) {
765757
// If raw log does exist, then the summary log is still being generated.
766758
this.warnInProgressEvalLogSummary();
767759
} else {

0 commit comments

Comments
 (0)