Skip to content

Commit 4450237

Browse files
committed
Add changelog note
And fix linting error.
1 parent 361fed6 commit 4450237

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

extensions/ql-vscode/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
- Remove support for CodeQL CLI versions older than 2.13.5. [#3371](https://github.com/github/vscode-codeql/pull/3371)
66
- Add a timeout to downloading databases and the CodeQL CLI. These can be changed using the `codeQL.addingDatabases.downloadTimeout` and `codeQL.cli.downloadTimeout` settings respectively. [#3373](https://github.com/github/vscode-codeql/pull/3373)
7+
- Databases created from [CodeQL test cases](https://docs.github.com/en/code-security/codeql-cli/using-the-advanced-functionality-of-the-codeql-cli/testing-custom-queries) are now copied into a shared VS Code storage location. This avoids a bug where re-running test cases would fail if the test's database is already imported into the workspace. [#3433](https://github.com/github/vscode-codeql/pull/3433)
78

89
## 1.12.2 - 14 February 2024
910

extensions/ql-vscode/src/databases/database-fetcher.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ async function fetchDatabaseToWorkspaceStorage(
370370
const unzipPath = await getStorageFolder(storagePath, databaseUrl);
371371

372372
if (isFile(databaseUrl)) {
373-
if (origin.type == "testproj") {
373+
if (origin.type === "testproj") {
374374
await copyDatabase(origin.path, unzipPath, progress);
375375
} else {
376376
await readAndUnzip(databaseUrl, unzipPath, cli, progress);

0 commit comments

Comments
 (0)