Skip to content

Commit 44b5828

Browse files
Merge pull request #2628 from github/robertbrignull/disposable
Merge definitions of Disposable where possible
2 parents c7b556e + f1a9289 commit 44b5828

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

extensions/ql-vscode/src/log-insights/log-scanner.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { SummaryEvent } from "./log-summary";
22
import { readJsonlFile } from "../common/jsonl-reader";
3+
import { Disposable } from "../common/disposable-object";
34

45
/**
56
* Callback interface used to report diagnostics from a log scanner.
@@ -62,13 +63,6 @@ export interface EvaluationLogScannerProvider {
6263
): EvaluationLogScanner;
6364
}
6465

65-
/**
66-
* Same as VSCode's `Disposable`, but avoids a dependency on VS Code.
67-
*/
68-
export interface Disposable {
69-
dispose(): void;
70-
}
71-
7266
export class EvaluationLogScannerSet {
7367
private readonly scannerProviders = new Map<
7468
number,

0 commit comments

Comments
 (0)