Reveal panel on navigate, to prevent webview destruction

asgerf · asgerf · commit 45b6288363a7 · 2022-10-19T14:09:38.000+02:00
diff --git a/extensions/ql-vscode/src/interface.ts b/extensions/ql-vscode/src/interface.ts
@@ -176,6 +176,11 @@ export class ResultsView extends AbstractWebview<IntoResultsViewMsg, FromResults
   }
 
   async navigateResultView(direction: NavigationDirection): Promise<void> {
+    if (!this.panel?.visible) {
+      return;
+    }
+    // Reveal the panel now as the subsequent call to 'Window.showTextEditor' in 'showLocation' may destroy the webview otherwise.
+    this.panel.reveal();
     await this.postMessage({ t: 'navigate', direction });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,11 @@ export class ResultsView extends AbstractWebview<IntoResultsViewMsg, FromResults`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`async navigateResultView(direction: NavigationDirection): Promise<void> {`
	`179`	`+ if (!this.panel?.visible) {`
	`180`	`+ return;`
	`181`	`+ }`
	`182`	`+ // Reveal the panel now as the subsequent call to 'Window.showTextEditor' in 'showLocation' may destroy the webview otherwise.`
	`183`	`+ this.panel.reveal();`
`179`	`184`	`await this.postMessage({ t: 'navigate', direction });`
`180`	`185`	`}`
`181`	`186`