Skip to content

Commit 4ad3d96

Browse files
committed
Add change note
Also, avoid a code scanning warning.
1 parent cc0e850 commit 4ad3d96

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

extensions/ql-vscode/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
- Sorted result set filenames now include a hash of the result set name instead of the full name. [#2955](https://github.com/github/vscode-codeql/pull/2955)
66
- The "Install Pack Dependencies" will now only list CodeQL packs located in the workspace. [#2960](https://github.com/github/vscode-codeql/pull/2960)
7+
- Fix a bug where the "View Query Log" action for a query history item was not working. [#2984](https://github.com/github/vscode-codeql/pull/2984)
78

89
## 1.9.2 - 12 October 2023
910

extensions/ql-vscode/src/query-results.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,7 @@ export class CompletedQueryInfo implements QueryWithResults {
7474
* Map from result set name to SortedResultSetInfo.
7575
*/
7676
public sortedResultsInfo: Record<string, SortedResultSetInfo> = {},
77-
) {
78-
// The log path is only set when loading from the query history.
79-
this.logFileLocation = logFileLocation ?? this.query.logPath;
80-
}
77+
) {}
8178

8279
setResultCount(value: number) {
8380
this.resultCount = value;
@@ -293,7 +290,7 @@ export class LocalQueryInfo {
293290
this.completedQuery = new CompletedQueryInfo(
294291
info.query,
295292
info.result,
296-
info.logFileLocation,
293+
info.query.logPath,
297294
info.successful,
298295
info.message,
299296
undefined,

0 commit comments

Comments
 (0)