Merge pull request #1841 from github/koesie10/fix-monitor-await

koesie10 · web-flow · commit 4bfefb8ebb4a · 2022-12-06T16:30:15.000+01:00
Fix incorrect await for monitor
diff --git a/extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts b/extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts
@@ -125,11 +125,7 @@ export class RemoteQueriesManager extends DisposableObject {
     } else if (status === QueryStatus.InProgress) {
       // In this case, last time we checked, the query was still in progress.
       // We need to setup the monitor to check for completion.
-      await commands.executeCommand(
-        "codeQL.monitorRemoteQuery",
-        queryId,
-        query,
-      );
+      void commands.executeCommand("codeQL.monitorRemoteQuery", queryId, query);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -125,11 +125,7 @@ export class RemoteQueriesManager extends DisposableObject {`
`125`	`125`	`} else if (status === QueryStatus.InProgress) {`
`126`	`126`	`// In this case, last time we checked, the query was still in progress.`
`127`	`127`	`// We need to setup the monitor to check for completion.`
`128`		`- await commands.executeCommand(`
`129`		`- "codeQL.monitorRemoteQuery",`
`130`		`- queryId,`
`131`		`- query,`
`132`		`- );`
	`128`	`+ void commands.executeCommand("codeQL.monitorRemoteQuery", queryId, query);`
`133`	`129`	`}`
`134`	`130`	`}`
`135`	`131`