Rename codeQL.createQuery.folder -> codeQL.createQuery.qlPackLocation

Author: elenatanasoiu

extensions/ql-vscode/package.json

@@ -341,7 +341,7 @@
           "default": false,
           "description": "Allow database to be downloaded via HTTP. Warning: enabling this option will allow downloading from insecure servers."
         },
-        "codeQL.createQuery.folder": {
+        "codeQL.createQuery.qlPackLocation": {
           "type": "string",
           "default": "",
           "patternErrorMessage": "Please enter a valid folder",

extensions/ql-vscode/src/config.ts

@@ -624,7 +624,7 @@ export function allowHttp(): boolean {
  * The name of the folder where we want to create skeleton wizard QL packs.
  **/
 const SKELETON_WIZARD_FOLDER = new Setting(
-  "folder",
+  "qlPackLocation",
   new Setting("createQuery", ROOT_SETTING),
 );
 

extensions/ql-vscode/test/vscode-tests/cli-integration/skeleton-query-wizard.test.ts

@@ -412,7 +412,7 @@ describe("SkeletonQueryWizard", () => {
 
         originalValue = workspace
           .getConfiguration("codeQL.createQuery")
-          .get("folder");
+          .get("qlPackLocation");
 
         // Set isCodespacesTemplate to true to indicate we are in the codespace template
         await workspace
@@ -423,7 +423,7 @@ describe("SkeletonQueryWizard", () => {
       afterEach(async () => {
         await workspace
           .getConfiguration("codeQL.createQuery")
-          .update("folder", originalValue);
+          .update("qlPackLocation", originalValue);
 
         await workspace
           .getConfiguration("codeQL")
@@ -449,16 +449,16 @@ describe("SkeletonQueryWizard", () => {
 
           originalValue = workspace
             .getConfiguration("codeQL.createQuery")
-            .get("folder");
+            .get("qlPackLocation");
           await workspace
             .getConfiguration("codeQL.createQuery")
-            .update("folder", storedPath);
+            .update("qlPackLocation", storedPath);
         });
 
         afterEach(async () => {
           await workspace
             .getConfiguration("codeQL.createQuery")
-            .update("folder", originalValue);
+            .update("qlPackLocation", originalValue);
         });
 
         it("should return it and not prompt the user", async () => {
@@ -478,16 +478,16 @@ describe("SkeletonQueryWizard", () => {
 
           originalValue = workspace
             .getConfiguration("codeQL.createQuery")
-            .get("folder");
+            .get("qlPackLocation");
           await workspace
             .getConfiguration("codeQL.createQuery")
-            .update("folder", storedPath);
+            .update("qlPackLocation", storedPath);
         });
 
         afterEach(async () => {
           await workspace
             .getConfiguration("codeQL.createQuery")
-            .update("folder", originalValue);
+            .update("qlPackLocation", originalValue);
         });
 
         it("should prompt the user for to provide a new folder name", async () => {