Fix RepoRow tests

Author: tuan-nguen

extensions/ql-vscode/src/view/variant-analysis/__tests__/RepoRow.spec.tsx

@@ -1,9 +1,4 @@
-import {
-  act,
-  render as reactRender,
-  screen,
-  waitFor,
-} from "@testing-library/react";
+import { act, render as reactRender, screen } from "@testing-library/react";
 import {
   VariantAnalysisRepoStatus,
   VariantAnalysisScannedRepositoryDownloadStatus,
@@ -403,15 +398,17 @@ describe(RepoRow.name, () => {
       status: VariantAnalysisRepoStatus.InProgress,
     });
 
-    expect(screen.getByRole("checkbox")).toBeDisabled();
+    const checkbox = await screen.findByRole("checkbox");
+    expect(checkbox).toBeDisabled();
   });
 
   it("does not allow selecting the item if the item has not been downloaded", async () => {
     render({
       status: VariantAnalysisRepoStatus.Succeeded,
     });
 
-    expect(screen.getByRole("checkbox")).toBeDisabled();
+    const checkbox = await screen.findByRole("checkbox");
+    expect(checkbox).toBeDisabled();
   });
 
   it("does not allow selecting the item if the item has not been downloaded successfully", async () => {
@@ -423,11 +420,8 @@ describe(RepoRow.name, () => {
       },
     });
 
-    // It seems like sometimes the first render doesn't have the checkbox disabled
-    // Might be related to https://github.com/microsoft/vscode-webview-ui-toolkit/issues/404
-    await waitFor(() => {
-      expect(screen.getByRole("checkbox")).toBeDisabled();
-    });
+    const checkbox = await screen.findByRole("checkbox");
+    expect(checkbox).toBeDisabled();
   });
 
   it("allows selecting the item if the item has been downloaded", async () => {
@@ -440,6 +434,7 @@ describe(RepoRow.name, () => {
       },
     });
 
-    expect(screen.getByRole("checkbox")).toBeEnabled();
+    const checkbox = await screen.findByRole("checkbox");
+    expect(checkbox).toBeEnabled();
   });
 });