Implement find-method suggestion

norascheuch · robertbrignull · norascheuch · commit 4ed0e0fa099b · 2022-10-24T10:40:03.000+02:00
Co-authored-by: Robert &lt;robertbrignull@github.com&gt;
diff --git a/extensions/ql-vscode/src/query-history.ts b/extensions/ql-vscode/src/query-history.ts
@@ -612,7 +612,7 @@ export class QueryHistoryManager extends DisposableObject {
     });
 
     const variantAnalysisRemovedSubscription = this.variantAnalysisManager.onVariantAnalysisRemoved(async (variantAnalysis) => {
-      const item = this.treeDataProvider.allHistory.find(i => i.t === 'variant-analysis' && i.historyItemId === variantAnalysis.id.toString());
+      const item = this.treeDataProvider.allHistory.find(i => i.t === 'variant-analysis' && i.variantAnalysis.id === variantAnalysis.id);
       if (item) {
         await this.removeRemoteQuery(item as RemoteQueryHistoryItem);
       }

Original file line number	Diff line number	Diff line change
`@@ -612,7 +612,7 @@ export class QueryHistoryManager extends DisposableObject {`
`612`	`612`	`});`
`613`	`613`
`614`	`614`	`const variantAnalysisRemovedSubscription = this.variantAnalysisManager.onVariantAnalysisRemoved(async (variantAnalysis) => {`
`615`		`- const item = this.treeDataProvider.allHistory.find(i => i.t === 'variant-analysis' && i.historyItemId === variantAnalysis.id.toString());`
	`615`	`+ const item = this.treeDataProvider.allHistory.find(i => i.t === 'variant-analysis' && i.variantAnalysis.id === variantAnalysis.id);`
`616`	`616`	`if (item) {`
`617`	`617`	`await this.removeRemoteQuery(item as RemoteQueryHistoryItem);`
`618`	`618`	`}`