Add tests for removing remote queries and variant analyses

Unfortunately, one of the tests we have for local queries doesn't seem
to be working for variant analyses. I'm not sure why it isn't
working, but I think it's better to get the rest of the integration
tests in and then figure out what's going on with that one.

Author: koesie10

extensions/ql-vscode/src/vscode-tests/factories/remote-queries/remote-query-history-item.ts

@@ -1,3 +1,4 @@
+import { nanoid } from "nanoid";
 import { RemoteQueryHistoryItem } from "../../../remote-queries/remote-query-history-item";
 import { QueryStatus } from "../../../query-status";
 
@@ -25,7 +26,7 @@ export function createMockRemoteQueryHistoryItem({
     resultCount,
     status,
     completed: false,
-    queryId: "queryId",
+    queryId: nanoid(),
     remoteQuery: {
       queryName: "query-name",
       queryFilePath: "query-file.ql",

extensions/ql-vscode/src/vscode-tests/no-workspace/query-history.test.ts

@@ -462,6 +462,141 @@ describe("query-history", () => {
           false,
         );
       });
+
+      it("should remove a remote query item and not select a new one", async () => {
+        queryHistoryManager = await createMockQueryHistory(allHistory);
+        // initialize the selection
+        await queryHistoryManager.treeView.reveal(remoteQueryHistory[0], {
+          select: true,
+        });
+
+        // deleting the first item when a different item is selected
+        // will not change the selection
+        const toDelete = remoteQueryHistory[1];
+        const selected = remoteQueryHistory[3];
+
+        // select the item we want
+        await queryHistoryManager.treeView.reveal(selected, { select: true });
+
+        // should be selected
+        expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
+          selected,
+        );
+
+        // remove an item
+        await queryHistoryManager.handleRemoveHistoryItem(toDelete, [toDelete]);
+
+        expect(remoteQueriesManagerStub.removeRemoteQuery).toHaveBeenCalledWith(
+          toDelete.queryId,
+        );
+        expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
+          selected,
+        );
+        expect(queryHistoryManager.treeDataProvider.allHistory).not.toContain(
+          toDelete,
+        );
+
+        // the same item should be selected
+        expect(
+          remoteQueriesManagerStub.openRemoteQueryResults,
+        ).toHaveBeenCalledWith(selected.queryId);
+      });
+
+      it("should remove a remote query item and select a new one", async () => {
+        queryHistoryManager = await createMockQueryHistory(remoteQueryHistory);
+
+        // deleting the selected item automatically selects next item
+        const toDelete = remoteQueryHistory[1];
+        const newSelected = remoteQueryHistory[2];
+
+        // select the item we want
+        await queryHistoryManager.treeView.reveal(toDelete, { select: true });
+        await queryHistoryManager.handleRemoveHistoryItem(toDelete, [toDelete]);
+
+        expect(remoteQueriesManagerStub.removeRemoteQuery).toHaveBeenCalledWith(
+          toDelete.queryId,
+        );
+        expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
+          newSelected,
+        );
+        expect(queryHistoryManager.treeDataProvider.allHistory).not.toContain(
+          toDelete,
+        );
+
+        // the current item should have been selected
+        expect(
+          remoteQueriesManagerStub.openRemoteQueryResults,
+        ).toHaveBeenCalledWith(newSelected.queryId);
+      });
+
+      it("should remove a variant analysis item and not select a new one", async () => {
+        queryHistoryManager = await createMockQueryHistory(allHistory);
+        // initialize the selection
+        await queryHistoryManager.treeView.reveal(variantAnalysisHistory[0], {
+          select: true,
+        });
+
+        // deleting the first item when a different item is selected
+        // will not change the selection
+        const toDelete = variantAnalysisHistory[1];
+        const selected = variantAnalysisHistory[3];
+
+        // select the item we want
+        await queryHistoryManager.treeView.reveal(selected, { select: true });
+
+        // should be selected
+        expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
+          selected,
+        );
+
+        // remove an item
+        await queryHistoryManager.handleRemoveHistoryItem(toDelete, [toDelete]);
+
+        expect(
+          variantAnalysisManagerStub.removeVariantAnalysis,
+        ).toHaveBeenCalledWith(toDelete.variantAnalysis);
+        expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
+          selected,
+        );
+        expect(queryHistoryManager.treeDataProvider.allHistory).not.toContain(
+          toDelete,
+        );
+
+        // the same item should be selected
+        expect(variantAnalysisManagerStub.showView).toHaveBeenCalledWith(
+          selected.variantAnalysis.id,
+        );
+      });
+
+      it("should remove a variant analysis item and select a new one", async () => {
+        queryHistoryManager = await createMockQueryHistory(
+          variantAnalysisHistory,
+        );
+
+        // deleting the selected item automatically selects next item
+        const toDelete = variantAnalysisHistory[1];
+        // const newSelected = variantAnalysisHistory[2];
+
+        // select the item we want
+        await queryHistoryManager.treeView.reveal(toDelete, { select: true });
+        await queryHistoryManager.handleRemoveHistoryItem(toDelete, [toDelete]);
+
+        expect(
+          variantAnalysisManagerStub.removeVariantAnalysis,
+        ).toHaveBeenCalledWith(toDelete.variantAnalysis);
+        expect(queryHistoryManager.treeDataProvider.allHistory).not.toContain(
+          toDelete,
+        );
+
+        // the current item should have been selected
+        // TODO: Make sure the correct item is selected
+        // expect(queryHistoryManager.treeDataProvider.getCurrent()).toEqual(
+        //   newSelected,
+        // );
+        // expect(variantAnalysisManagerStub.showView).toHaveBeenCalledWith(
+        //   newSelected.variantAnalysis.id,
+        // );
+      });
     });
 
     describe("handleCancel", () => {