Skip to content

Commit 5079abd

Browse files
committed
Fix version constraint
Non-destructive upgrades only exist in versions >= 2.4.2
1 parent 4e94f70 commit 5079abd

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

extensions/ql-vscode/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## [UNRELEASED]
44

5+
- Fix version constraint for flagging CLI support of non-destructive updates [#744](https://github.com/github/vscode-codeql/pull/744)
6+
57
## 1.4.1 - 29 January 2021
68

79
- Reword the telemetry modal dialog box. [#738](https://github.com/github/vscode-codeql/pull/738)

extensions/ql-vscode/src/upgrades.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const MAX_UPGRADE_MESSAGE_LINES = 10;
2525
* resolving upgrades. We check for a version of codeql that has all three features.
2626
*/
2727
export async function hasNondestructiveUpgradeCapabilities(qs: qsClient.QueryServerClient): Promise<boolean> {
28-
return semver.gte(await qs.cliServer.getVersion(), '2.4.1');
28+
return semver.gte(await qs.cliServer.getVersion(), '2.4.2');
2929
}
3030

3131

0 commit comments

Comments
 (0)