Skip to content

Commit 50efdea

Browse files
committed
Remove build before launch in launch.json
And update contributing with new instructions.
1 parent 9300c07 commit 50efdea

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

.vscode/launch.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"outFiles": [
1616
"${workspaceRoot}/extensions/ql-vscode/out/**/*.js",
1717
],
18-
"preLaunchTask": "Build",
1918
"env": {
2019
// uncomment to allow debugging the language server Java process from a remote java debugger
2120
// "DEBUG_LANGUAGE_SERVER": "true"
@@ -62,7 +61,6 @@
6261
"outFiles": [
6362
"${workspaceRoot}/extensions/ql-vscode/out/**/*.js",
6463
],
65-
"preLaunchTask": "Build"
6664
},
6765
{
6866
"name": "Launch Integration Tests - Minimal Workspace (vscode-codeql)",
@@ -79,7 +77,6 @@
7977
"outFiles": [
8078
"${workspaceRoot}/extensions/ql-vscode/out/**/*.js",
8179
],
82-
"preLaunchTask": "Build"
8380
}
8481
]
8582
}

CONTRIBUTING.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,18 @@ From the command line, go to the directory `extensions/ql-vscode` and run
4646

4747
```shell
4848
npm run build
49+
npm run watch
4950
```
5051

51-
Alternatively, you can build the extension within VS Code via `Terminal > Run Build Task...` (or `Ctrl+Shift+B` with the default key bindings).
52+
Alternatively, you can build the extension within VS Code via `Terminal > Run Build Task...` (or `Ctrl+Shift+B` with the default key bindings). And you can run the watch command via `Terminal > Run Task` and then select `npm watch` from the menu.
53+
54+
Before running any of the launch commands, be sure to have run the `build` command to ensure that the JavaScript is compiled and the resources are copied to the proper location.
55+
56+
We recommend that you keep`npm run watch` running in the backgound and you only need to re-run `npm run build` in the following situations:
57+
58+
1. on first checkout
59+
2. whenever any of the non-TypeScript resources have changed
60+
3. on any change to files included in the webview
5261

5362
### Installing the extension
5463

0 commit comments

Comments
 (0)