Skip to content

Commit 51c81f9

Browse files
Move setState call later
1 parent 9eb7f96 commit 51c81f9

File tree

1 file changed

+21
-23
lines changed

1 file changed

+21
-23
lines changed

extensions/ql-vscode/src/view/results/ResultsApp.tsx

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -79,31 +79,29 @@ export function ResultsApp() {
7979

8080
const updateStateWithNewResultsInfo = useCallback(
8181
(resultsInfo: ResultsInfo): void => {
82-
setState(() => {
83-
let results: Results | null = null;
84-
let statusText = "";
85-
try {
86-
const resultSets = getResultSets(resultsInfo);
87-
results = {
88-
resultSets,
89-
database: resultsInfo.database,
90-
sortStates: getSortStates(resultsInfo),
91-
};
92-
} catch (e) {
93-
const errorMessage = getErrorMessage(e);
82+
let results: Results | null = null;
83+
let statusText = "";
84+
try {
85+
const resultSets = getResultSets(resultsInfo);
86+
results = {
87+
resultSets,
88+
database: resultsInfo.database,
89+
sortStates: getSortStates(resultsInfo),
90+
};
91+
} catch (e) {
92+
const errorMessage = getErrorMessage(e);
9493

95-
statusText = `Error loading results: ${errorMessage}`;
96-
}
94+
statusText = `Error loading results: ${errorMessage}`;
95+
}
9796

98-
return {
99-
displayedResults: {
100-
resultsInfo,
101-
results,
102-
errorMessage: statusText,
103-
},
104-
nextResultsInfo: null,
105-
isExpectingResultsUpdate: false,
106-
};
97+
setState({
98+
displayedResults: {
99+
resultsInfo,
100+
results,
101+
errorMessage: statusText,
102+
},
103+
nextResultsInfo: null,
104+
isExpectingResultsUpdate: false,
107105
});
108106
},
109107
[],

0 commit comments

Comments
 (0)