Skip to content

Commit 52972f0

Browse files
Make completedRepositoryCount non-optional
We're always passing in a non-undefined number anyway, so this optional value isn't giving us any benefit.
1 parent 6f11eca commit 52972f0

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisRepositoriesStats.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ type Props = {
1212
variantAnalysisStatus: VariantAnalysisStatus;
1313

1414
totalRepositoryCount: number;
15-
completedRepositoryCount?: number | undefined;
15+
completedRepositoryCount: number;
1616

1717
showWarning?: boolean;
1818
};
1919

2020
export const VariantAnalysisRepositoriesStats = ({
2121
variantAnalysisStatus,
2222
totalRepositoryCount,
23-
completedRepositoryCount = 0,
23+
completedRepositoryCount,
2424
showWarning,
2525
}: Props) => {
2626
if (variantAnalysisStatus === VariantAnalysisStatus.Failed) {

extensions/ql-vscode/src/view/variant-analysis/VariantAnalysisStats.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export type VariantAnalysisStatsProps = {
1212
variantAnalysisStatus: VariantAnalysisStatus;
1313

1414
totalRepositoryCount: number;
15-
completedRepositoryCount?: number | undefined;
15+
completedRepositoryCount: number;
1616

1717
hasWarnings?: boolean;
1818

@@ -32,7 +32,7 @@ const Row = styled.div`
3232
export const VariantAnalysisStats = ({
3333
variantAnalysisStatus,
3434
totalRepositoryCount,
35-
completedRepositoryCount = 0,
35+
completedRepositoryCount,
3636
hasWarnings,
3737
resultCount,
3838
createdAt,

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysisStats.spec.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ describe(VariantAnalysisStats.name, () => {
1919
<VariantAnalysisStats
2020
variantAnalysisStatus={VariantAnalysisStatus.InProgress}
2121
totalRepositoryCount={10}
22+
completedRepositoryCount={0}
2223
onViewLogsClick={onViewLogsClick}
2324
createdAt={new Date()}
2425
{...props}

0 commit comments

Comments
 (0)