Skip to content

Commit 530ae68

Browse files
committed
Use strictly type choices for config setting
1 parent c8b0b1c commit 530ae68

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

extensions/ql-vscode/src/config.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -646,10 +646,14 @@ const AUTOGENERATE_QL_PACKS = new Setting(
646646
CREATE_QUERY_COMMAND,
647647
);
648648

649-
export function getAutogenerateQlPacks(): string | undefined {
650-
return AUTOGENERATE_QL_PACKS.getValue<string>() || undefined;
649+
const AutogenerateQLPacksValues = ["ask", "yes", "never"] as const;
650+
type AutogenerateQLPacks = typeof AutogenerateQLPacksValues[number];
651+
652+
export function getAutogenerateQlPacks(): AutogenerateQLPacks {
653+
const value = AUTOGENERATE_QL_PACKS.getValue<AutogenerateQLPacks>();
654+
return AutogenerateQLPacksValues.includes(value) ? value : "ask";
651655
}
652656

653-
export async function setAutogenerateQlPacks(choice: string | undefined) {
657+
export async function setAutogenerateQlPacks(choice: AutogenerateQLPacks) {
654658
await AUTOGENERATE_QL_PACKS.updateValue(choice, ConfigurationTarget.Global);
655659
}

0 commit comments

Comments
 (0)