Add explicit return type to convertToLegacyModeledMethod

Author: koesie10

extensions/ql-vscode/src/model-editor/method-modeling/method-modeling-view-provider.ts

@@ -150,10 +150,13 @@ export class MethodModelingViewProvider extends AbstractWebviewViewProvider<
         if (this.webviewView && e.isActiveDb) {
           const modeledMethods = e.modeledMethods[this.method?.signature ?? ""];
           if (modeledMethods) {
-            await this.postMessage({
-              t: "setModeledMethod",
-              method: convertToLegacyModeledMethod(modeledMethods),
-            });
+            const modeledMethod = convertToLegacyModeledMethod(modeledMethods);
+            if (modeledMethod) {
+              await this.postMessage({
+                t: "setModeledMethod",
+                method: modeledMethod,
+              });
+            }
           }
         }
       }),

extensions/ql-vscode/src/model-editor/modeled-methods-legacy.ts

@@ -37,9 +37,15 @@ export function convertToLegacyModeledMethods(
 ): Record<string, ModeledMethod> {
   // Always take the first modeled method in the array
   return Object.fromEntries(
-    Object.entries(modeledMethods).map(([signature, modeledMethods]) => {
-      return [signature, convertToLegacyModeledMethod(modeledMethods)];
-    }),
+    Object.entries(modeledMethods)
+      .map(([signature, modeledMethods]) => {
+        const modeledMethod = convertToLegacyModeledMethod(modeledMethods);
+        if (!modeledMethod) {
+          return null;
+        }
+        return [signature, modeledMethod];
+      })
+      .filter((entry): entry is [string, ModeledMethod] => entry !== null),
   );
 }
 
@@ -66,6 +72,8 @@ export function convertFromLegacyModeledMethod(modeledMethod: ModeledMethod) {
  *
  * @param modeledMethods The ModeledMethod[]
  */
-export function convertToLegacyModeledMethod(modeledMethods: ModeledMethod[]) {
+export function convertToLegacyModeledMethod(
+  modeledMethods: ModeledMethod[],
+): ModeledMethod | undefined {
   return modeledMethods[0];
 }