Fix test code

Author: Dave Bartolomeo

extensions/ql-vscode/test/factories/query-history/local-query-history-item.ts

@@ -74,7 +74,6 @@ export function createMockQueryWithResults({
   hasInterpretedResults?: boolean;
   hasMetadata?: boolean;
 }): QueryWithResults {
-  const dispose = jest.fn();
   const deleteQuery = jest.fn();
   const metadata = hasMetadata
     ? ({ name: "query-name" } as QueryMetadata)
@@ -87,7 +86,6 @@ export function createMockQueryWithResults({
       metadata,
     } as unknown as QueryEvaluationInfo,
     successful: didRunSuccessfully,
-    dispose,
     result: {
       evaluationTime: 1,
       queryId: 0,

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/query-history-manager.test.ts

@@ -344,7 +344,6 @@ describe("QueryHistoryManager", () => {
         });
 
         it("should remove the item", () => {
-          expect(toDelete.completedQuery!.dispose).toBeCalledTimes(1);
           expect(queryHistoryManager.treeDataProvider.allHistory).toEqual(
             expect.not.arrayContaining([toDelete]),
           );
@@ -387,7 +386,6 @@ describe("QueryHistoryManager", () => {
         });
 
         it("should remove the item", () => {
-          expect(toDelete.completedQuery!.dispose).toBeCalledTimes(1);
           expect(queryHistoryManager.treeDataProvider.allHistory).toEqual(
             expect.not.arrayContaining([toDelete]),
           );

extensions/ql-vscode/test/vscode-tests/no-workspace/query-results.test.ts

@@ -470,7 +470,6 @@ describe("query-results", () => {
       query: query.queryEvalInfo,
       successful: didRunSuccessfully,
       message: "foo",
-      dispose: jest.fn(),
       result: {
         evaluationTime: 1,
         queryId: 0,

extensions/ql-vscode/test/vscode-tests/no-workspace/query-serialization.test.ts

@@ -259,7 +259,6 @@ describe("serialize and deserialize", () => {
       query: query.queryEvalInfo,
       successful: didRunSuccessfully,
       message: "foo",
-      dispose: jest.fn(),
       result: {
         evaluationTime: 1,
         queryId: 0,

extensions/ql-vscode/test/vscode-tests/no-workspace/run-queries.test.ts

@@ -190,6 +190,7 @@ describe("run-queries", () => {
         mockQlProgram,
         mockProgress as any,
         mockCancel as any,
+        qs.logger,
       );
 
       expect(results).toEqual([{ message: "err", severity: Severity.ERROR }]);