Skip to content

Commit 563720b

Browse files
Rename SortableResult => FilterAndSortableResult
1 parent d30ca71 commit 563720b

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

extensions/ql-vscode/src/pure/variant-analysis-filter-sort.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,17 +78,17 @@ export function compareRepository(
7878
};
7979
}
8080

81-
type SortableResult = {
81+
type FilterAndSortableResult = {
8282
repository: SortableRepository & Pick<Repository, "id">;
8383
resultCount?: number;
8484
};
8585

8686
export function compareWithResults(
8787
filterSortState: RepositoriesFilterSortState | undefined,
88-
): (left: SortableResult, right: SortableResult) => number {
88+
): (left: FilterAndSortableResult, right: FilterAndSortableResult) => number {
8989
const fallbackSort = compareRepository(filterSortState);
9090

91-
return (left: SortableResult, right: SortableResult) => {
91+
return (left: FilterAndSortableResult, right: FilterAndSortableResult) => {
9292
// Highest to lowest
9393
if (filterSortState?.sortKey === SortKey.ResultsCount) {
9494
const resultCount = (right.resultCount ?? 0) - (left.resultCount ?? 0);
@@ -102,7 +102,7 @@ export function compareWithResults(
102102
}
103103

104104
export function filterAndSortRepositoriesWithResultsByName<
105-
T extends SortableResult,
105+
T extends FilterAndSortableResult,
106106
>(
107107
repositories: T[] | undefined,
108108
filterSortState: RepositoriesFilterSortState | undefined,
@@ -116,7 +116,9 @@ export function filterAndSortRepositoriesWithResultsByName<
116116
.sort(compareWithResults(filterSortState));
117117
}
118118

119-
export function filterAndSortRepositoriesWithResults<T extends SortableResult>(
119+
export function filterAndSortRepositoriesWithResults<
120+
T extends FilterAndSortableResult,
121+
>(
120122
repositories: T[] | undefined,
121123
filterSortState: RepositoriesFilterSortStateWithIds | undefined,
122124
): T[] | undefined {

0 commit comments

Comments
 (0)