Use proper check for existence of search path

aeisenberg · aeisenberg · commit 565ea0d8a0e8 · 2020-07-16T09:10:05.000-07:00
Fixes #499
diff --git a/extensions/ql-vscode/src/cli.ts b/extensions/ql-vscode/src/cli.ts
@@ -604,7 +604,7 @@ export class CodeQLCliServer implements Disposable {
    */
   resolveQlpacks(additionalPacks: string[], searchPath?: string[]): Promise<QlpacksInfo> {
     const args = ['--additional-packs', additionalPacks.join(path.delimiter)];
-    if (searchPath !== undefined) {
+    if (searchPath?.length) {
       args.push('--search-path', path.join(...searchPath));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -604,7 +604,7 @@ export class CodeQLCliServer implements Disposable {`
`604`	`604`	`*/`
`605`	`605`	`resolveQlpacks(additionalPacks: string[], searchPath?: string[]): Promise<QlpacksInfo> {`
`606`	`606`	`const args = ['--additional-packs', additionalPacks.join(path.delimiter)];`
`607`		`- if (searchPath !== undefined) {`
	`607`	`+ if (searchPath?.length) {`
`608`	`608`	`args.push('--search-path', path.join(...searchPath));`
`609`	`609`	`}`
`610`	`610`