Skip to content

Commit 567cb10

Browse files
authored
Merge pull request #2793 from github/koesie10/feature-flag-flow-generation
Add feature flag for flow generation
2 parents 4531286 + 13c2f59 commit 567cb10

File tree

6 files changed

+22
-12
lines changed

6 files changed

+22
-12
lines changed

extensions/ql-vscode/src/config.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -706,9 +706,14 @@ export function showQueriesPanel(): boolean {
706706
}
707707

708708
const MODEL_SETTING = new Setting("model", ROOT_SETTING);
709+
const FLOW_GENERATION = new Setting("flowGeneration", MODEL_SETTING);
709710
const LLM_GENERATION = new Setting("llmGeneration", MODEL_SETTING);
710711
const EXTENSIONS_DIRECTORY = new Setting("extensionsDirectory", MODEL_SETTING);
711712

713+
export function showFlowGeneration(): boolean {
714+
return !!FLOW_GENERATION.getValue<boolean>();
715+
}
716+
712717
export function showLlmGeneration(): boolean {
713718
return !!LLM_GENERATION.getValue<boolean>();
714719
}

extensions/ql-vscode/src/model-editor/model-editor-view.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import {
3434
import { Method, Usage } from "./method";
3535
import { ModeledMethod } from "./modeled-method";
3636
import { ExtensionPack } from "./shared/extension-pack";
37-
import { showLlmGeneration } from "../config";
37+
import { showFlowGeneration, showLlmGeneration } from "../config";
3838
import { Mode } from "./shared/mode";
3939
import { loadModeledMethods, saveModeledMethods } from "./modeled-method-fs";
4040
import { join } from "path";
@@ -322,6 +322,7 @@ export class ModelEditorView extends AbstractWebview<
322322
t: "setModelEditorViewState",
323323
viewState: {
324324
extensionPack: this.extensionPack,
325+
showFlowGeneration: showFlowGeneration(),
325326
showLlmButton,
326327
mode: this.mode,
327328
},

extensions/ql-vscode/src/model-editor/shared/view-state.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { Mode } from "./mode";
33

44
export interface ModelEditorViewState {
55
extensionPack: ExtensionPack;
6+
showFlowGeneration: boolean;
67
showLlmButton: boolean;
78
mode: Mode;
89
}

extensions/ql-vscode/src/stories/model-editor/ModelEditor.stories.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ ModelEditor.args = {
2828
extensionTargets: {},
2929
dataExtensions: [],
3030
},
31+
showFlowGeneration: true,
3132
showLlmButton: true,
3233
mode: Mode.Application,
3334
},

extensions/ql-vscode/src/view/model-editor/LibraryRow.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -213,12 +213,13 @@ export const LibraryRow = ({
213213
&nbsp;Stop
214214
</VSCodeButton>
215215
)}
216-
{viewState.mode === Mode.Application && (
217-
<VSCodeButton appearance="icon" onClick={handleModelFromSource}>
218-
<Codicon name="code" label="Model from source" />
219-
&nbsp;Model from source
220-
</VSCodeButton>
221-
)}
216+
{viewState.showFlowGeneration &&
217+
viewState.mode === Mode.Application && (
218+
<VSCodeButton appearance="icon" onClick={handleModelFromSource}>
219+
<Codicon name="code" label="Model from source" />
220+
&nbsp;Model from source
221+
</VSCodeButton>
222+
)}
222223
{viewState.mode === Mode.Application && (
223224
<VSCodeButton appearance="icon" onClick={handleModelDependency}>
224225
<Codicon name="references" label="Model dependency" />

extensions/ql-vscode/src/view/model-editor/ModelEditor.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -345,11 +345,12 @@ export function ModelEditor({
345345
<VSCodeButton appearance="secondary" onClick={onRefreshClick}>
346346
Refresh
347347
</VSCodeButton>
348-
{viewState.mode === Mode.Framework && (
349-
<VSCodeButton onClick={onGenerateFromSourceClick}>
350-
Generate
351-
</VSCodeButton>
352-
)}
348+
{viewState.showFlowGeneration &&
349+
viewState.mode === Mode.Framework && (
350+
<VSCodeButton onClick={onGenerateFromSourceClick}>
351+
Generate
352+
</VSCodeButton>
353+
)}
353354
</ButtonsContainer>
354355
<ModeledMethodsList
355356
methods={methods}

0 commit comments

Comments
 (0)