Don't mention splat/slurp in comments or descriptions

Author: elenatanasoiu

extensions/ql-vscode/src/query-serialization.ts

@@ -48,7 +48,7 @@ export async function deserializeQueryHistory(
             q.completedQuery.query,
             QueryEvaluationInfo.prototype,
           );
-          // slurped queries do not need to be disposed
+          // deserialized queries do not need to be disposed
           q.completedQuery.dispose = () => {
             /**/
           };
@@ -83,7 +83,7 @@ export async function deserializeQueryHistory(
     // queries aged out.
     return asyncFilter(parsedQueries, async (q) => {
       if (q.t === "remote" || q.t === "variant-analysis") {
-        // the slurper doesn't know where the remote queries are stored
+        // the deserializer doesn't know where the remote queries are stored
         // so we need to assume here that they exist. Later, we check to
         // see if they exist on disk.
         return true;

extensions/ql-vscode/test/vscode-tests/no-workspace/query-results.test.ts

@@ -438,7 +438,7 @@ describe("query-results", () => {
     );
   });
 
-  describe("splat and slurp", () => {
+  describe("serialize and deserialize", () => {
     let infoSuccessRaw: LocalQueryInfo;
     let infoSuccessInterpreted: LocalQueryInfo;
     let infoEarlyFailure: LocalQueryInfo;
@@ -488,7 +488,7 @@ describe("query-results", () => {
       ];
     });
 
-    it("should splat and slurp query history", async () => {
+    it("should serialize and deserialize query history", async () => {
       // the expected results only contains the history with completed queries
       const expectedHistory = [
         infoSuccessRaw,
@@ -498,7 +498,7 @@ describe("query-results", () => {
 
       const allHistoryPath = join(tmpDir.name, "workspace-query-history.json");
 
-      // splat and slurp
+      // serialize and deserialize
       await serializeQueryHistory(allHistory, allHistoryPath);
       const allHistoryActual = await deserializeQueryHistory(allHistoryPath);
 
@@ -508,7 +508,7 @@ describe("query-results", () => {
           const completedQuery = info.completedQuery;
           (completedQuery as any).dispose = undefined;
 
-          // these fields should be missing on the slurped value
+          // these fields should be missing on the deserialized value
           // but they are undefined on the original value
           if (!("logFileLocation" in completedQuery)) {
             (completedQuery as any).logFileLocation = undefined;