Skip to content

Commit 58afeba

Browse files
committed
Apply a background color to the pipeline header rows
1 parent 8268d68 commit 58afeba

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,10 @@ function PipelineStep(props: PipelineStepProps) {
216216
);
217217
}
218218

219+
const HeaderTR = styled.tr`
220+
background-color: var(--vscode-sideBar-background);
221+
`;
222+
219223
interface HighLevelStatsProps {
220224
before: PredicateInfo;
221225
after: PredicateInfo;
@@ -229,13 +233,13 @@ function HighLevelStats(props: HighLevelStatsProps) {
229233
before.evaluationCount > 1 || after.evaluationCount > 1;
230234
return (
231235
<>
232-
<tr>
236+
<HeaderTR>
233237
<ChevronCell></ChevronCell>
234238
<NumberHeader>{hasBefore ? "Before" : ""}</NumberHeader>
235239
<NumberHeader>{hasAfter ? "After" : ""}</NumberHeader>
236240
<NumberHeader>{hasBefore && hasAfter ? "Delta" : ""}</NumberHeader>
237241
<NameHeader>Stats</NameHeader>
238-
</tr>
242+
</HeaderTR>
239243
{showEvaluationCount && (
240244
<PipelineStep
241245
before={before.evaluationCount || undefined}
@@ -393,13 +397,13 @@ export function ComparePerformance(_: Record<string, never>) {
393397
</SortOrderDropdown>
394398
<Table>
395399
<thead>
396-
<tr>
400+
<HeaderTR>
397401
<ChevronCell />
398402
<NumberHeader>Before</NumberHeader>
399403
<NumberHeader>After</NumberHeader>
400404
<NumberHeader>Delta</NumberHeader>
401405
<NameHeader>Predicate</NameHeader>
402-
</tr>
406+
</HeaderTR>
403407
</thead>
404408
</Table>
405409
{rows.map((row) => (
@@ -433,7 +437,7 @@ export function ComparePerformance(_: Record<string, never>) {
433437
row.after.pipelines,
434438
).map(({ name, first, second }, pipelineIndex) => (
435439
<Fragment key={pipelineIndex}>
436-
<tr>
440+
<HeaderTR>
437441
<td></td>
438442
<NumberHeader>{first != null && "Before"}</NumberHeader>
439443
<NumberHeader>{second != null && "After"}</NumberHeader>
@@ -448,7 +452,7 @@ export function ComparePerformance(_: Record<string, never>) {
448452
? " (before)"
449453
: ""}
450454
</NameHeader>
451-
</tr>
455+
</HeaderTR>
452456
{abbreviateRASteps(first?.steps ?? second!.steps).map(
453457
(step, index) => (
454458
<PipelineStep

0 commit comments

Comments
 (0)