Skip to content

Commit 58e69c8

Browse files
committed
Use switch instead of conditional.
1 parent 5c90e5f commit 58e69c8

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

extensions/ql-vscode/src/interface.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,22 @@ export function webviewUriToFileUri(webviewUri: string): Uri {
8686
return Uri.file(path);
8787
}
8888

89+
function sortMultiplier(sortDirection: SortDirection): number {
90+
switch (sortDirection) {
91+
case SortDirection.asc: return 1;
92+
case SortDirection.desc: return -1;
93+
}
94+
}
95+
8996
function sortInterpretedResults(results: Sarif.Result[], sortState: InterpretedResultsSortState | undefined): void {
9097
if (sortState !== undefined) {
91-
const direction = sortState.sortDirection === SortDirection.asc ? 1 : -1;
98+
const multiplier = sortMultiplier(sortState.sortDirection);
9299
switch (sortState.sortBy) {
93100
case 'alert-message':
94101
results.sort((a, b) =>
95102
a.message.text === undefined ? 0 :
96103
b.message.text === undefined ? 0 :
97-
direction * (a.message.text?.localeCompare(b.message.text)));
104+
multiplier * (a.message.text?.localeCompare(b.message.text)));
98105
break;
99106
default:
100107
assertNever(sortState.sortBy);

0 commit comments

Comments
 (0)