Skip to content

Commit 5c2050d

Browse files
committed
Extract addModeledMethodsFromArray method
1 parent bb104b5 commit 5c2050d

File tree

1 file changed

+16
-24
lines changed

1 file changed

+16
-24
lines changed

extensions/ql-vscode/src/model-editor/model-editor-view.ts

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -515,19 +515,7 @@ export class ModelEditorView extends AbstractWebview<
515515
databaseItem: addedDatabase ?? this.databaseItem,
516516
language: this.language,
517517
onResults: async (modeledMethods) => {
518-
const modeledMethodsByName: Record<string, ModeledMethod[]> = {};
519-
520-
for (const modeledMethod of modeledMethods) {
521-
if (!(modeledMethod.signature in modeledMethodsByName)) {
522-
modeledMethodsByName[modeledMethod.signature] = [];
523-
}
524-
525-
modeledMethodsByName[modeledMethod.signature].push(
526-
modeledMethod,
527-
);
528-
}
529-
530-
this.addModeledMethods(modeledMethodsByName);
518+
this.addModeledMethodsFromArray(modeledMethods);
531519
},
532520
progress,
533521
token: tokenSource.token,
@@ -563,17 +551,7 @@ export class ModelEditorView extends AbstractWebview<
563551
token: tokenSource.token,
564552
});
565553

566-
const modeledMethodsByName: Record<string, ModeledMethod[]> = {};
567-
568-
for (const modeledMethod of modeledMethods) {
569-
if (!(modeledMethod.signature in modeledMethodsByName)) {
570-
modeledMethodsByName[modeledMethod.signature] = [];
571-
}
572-
573-
modeledMethodsByName[modeledMethod.signature].push(modeledMethod);
574-
}
575-
576-
this.addModeledMethods(modeledMethodsByName);
554+
this.addModeledMethodsFromArray(modeledMethods);
577555
} catch (e: unknown) {
578556
void showAndLogExceptionWithTelemetry(
579557
this.app.logger,
@@ -806,6 +784,20 @@ export class ModelEditorView extends AbstractWebview<
806784
);
807785
}
808786

787+
private addModeledMethodsFromArray(modeledMethods: ModeledMethod[]) {
788+
const modeledMethodsByName: Record<string, ModeledMethod[]> = {};
789+
790+
for (const modeledMethod of modeledMethods) {
791+
if (!(modeledMethod.signature in modeledMethodsByName)) {
792+
modeledMethodsByName[modeledMethod.signature] = [];
793+
}
794+
795+
modeledMethodsByName[modeledMethod.signature].push(modeledMethod);
796+
}
797+
798+
this.addModeledMethods(modeledMethodsByName);
799+
}
800+
809801
private setModeledMethods(signature: string, methods: ModeledMethod[]) {
810802
this.modelingStore.updateModeledMethods(
811803
this.databaseItem,

0 commit comments

Comments
 (0)