Skip to content

Commit 5d2e205

Browse files
authored
Rename 'dependency' to 'package' in auto-modeling code (#2686)
1 parent b1dc862 commit 5d2e205

File tree

5 files changed

+24
-24
lines changed

5 files changed

+24
-24
lines changed

extensions/ql-vscode/src/common/interface-types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -549,14 +549,14 @@ interface GenerateExternalApiMessage {
549549

550550
interface GenerateExternalApiFromLlmMessage {
551551
t: "generateExternalApiFromLlm";
552-
dependencyName: string;
552+
packageName: string;
553553
externalApiUsages: ExternalApiUsage[];
554554
modeledMethods: Record<string, ModeledMethod>;
555555
}
556556

557557
interface StopGeneratingExternalApiFromLlmMessage {
558558
t: "stopGeneratingExternalApiFromLlm";
559-
dependencyName: string;
559+
packageName: string;
560560
}
561561

562562
interface ModelDependencyMessage {

extensions/ql-vscode/src/data-extensions-editor/auto-modeler.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,34 +42,34 @@ export class AutoModeler {
4242
}
4343

4444
public async startModeling(
45-
dependency: string,
45+
packageName: string,
4646
externalApiUsages: ExternalApiUsage[],
4747
modeledMethods: Record<string, ModeledMethod>,
4848
mode: Mode,
4949
): Promise<void> {
50-
if (this.jobs.has(dependency)) {
50+
if (this.jobs.has(packageName)) {
5151
return;
5252
}
5353

5454
const cancellationTokenSource = new CancellationTokenSource();
55-
this.jobs.set(dependency, cancellationTokenSource);
55+
this.jobs.set(packageName, cancellationTokenSource);
5656

5757
try {
58-
await this.modelDependency(
59-
dependency,
58+
await this.modelPackage(
59+
packageName,
6060
externalApiUsages,
6161
modeledMethods,
6262
mode,
6363
cancellationTokenSource,
6464
);
6565
} finally {
66-
this.jobs.delete(dependency);
66+
this.jobs.delete(packageName);
6767
}
6868
}
6969

70-
public async stopModeling(dependency: string): Promise<void> {
71-
void extLogger.log(`Stopping modeling for dependency ${dependency}`);
72-
const cancellationTokenSource = this.jobs.get(dependency);
70+
public async stopModeling(packageName: string): Promise<void> {
71+
void extLogger.log(`Stopping modeling for package ${packageName}`);
72+
const cancellationTokenSource = this.jobs.get(packageName);
7373
if (cancellationTokenSource) {
7474
cancellationTokenSource.cancel();
7575
}
@@ -81,14 +81,14 @@ export class AutoModeler {
8181
}
8282
}
8383

84-
private async modelDependency(
85-
dependency: string,
84+
private async modelPackage(
85+
packageName: string,
8686
externalApiUsages: ExternalApiUsage[],
8787
modeledMethods: Record<string, ModeledMethod>,
8888
mode: Mode,
8989
cancellationTokenSource: CancellationTokenSource,
9090
): Promise<void> {
91-
void extLogger.log(`Modeling dependency ${dependency}`);
91+
void extLogger.log(`Modeling package ${packageName}`);
9292
await withProgress(async (progress) => {
9393
const maxStep = 3000;
9494

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
177177
case "generateExternalApiFromLlm":
178178
if (useLlmGenerationV2()) {
179179
await this.generateModeledMethodsFromLlmV2(
180-
msg.dependencyName,
180+
msg.packageName,
181181
msg.externalApiUsages,
182182
msg.modeledMethods,
183183
);
@@ -189,7 +189,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
189189
}
190190
break;
191191
case "stopGeneratingExternalApiFromLlm":
192-
await this.autoModeler.stopModeling(msg.dependencyName);
192+
await this.autoModeler.stopModeling(msg.packageName);
193193
break;
194194
case "modelDependency":
195195
await this.modelDependency();
@@ -459,12 +459,12 @@ export class DataExtensionsEditorView extends AbstractWebview<
459459
}
460460

461461
private async generateModeledMethodsFromLlmV2(
462-
dependency: string,
462+
packageName: string,
463463
externalApiUsages: ExternalApiUsage[],
464464
modeledMethods: Record<string, ModeledMethod>,
465465
): Promise<void> {
466466
await this.autoModeler.startModeling(
467-
dependency,
467+
packageName,
468468
externalApiUsages,
469469
modeledMethods,
470470
this.mode,

extensions/ql-vscode/src/view/data-extensions-editor/DataExtensionsEditor.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,24 +227,24 @@ export function DataExtensionsEditor({
227227

228228
const onGenerateFromLlmClick = useCallback(
229229
(
230-
dependencyName: string,
230+
packageName: string,
231231
externalApiUsages: ExternalApiUsage[],
232232
modeledMethods: Record<string, ModeledMethod>,
233233
) => {
234234
vscode.postMessage({
235235
t: "generateExternalApiFromLlm",
236-
dependencyName,
236+
packageName,
237237
externalApiUsages,
238238
modeledMethods,
239239
});
240240
},
241241
[],
242242
);
243243

244-
const onStopGenerateFromLlmClick = useCallback((dependencyName: string) => {
244+
const onStopGenerateFromLlmClick = useCallback((packageName: string) => {
245245
vscode.postMessage({
246246
t: "stopGeneratingExternalApiFromLlm",
247-
dependencyName,
247+
packageName,
248248
});
249249
}, []);
250250

extensions/ql-vscode/src/view/data-extensions-editor/ModeledMethodsList.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ type Props = {
2727
modeledMethods: Record<string, ModeledMethod>,
2828
) => void;
2929
onGenerateFromLlmClick: (
30-
dependencyName: string,
30+
packageName: string,
3131
externalApiUsages: ExternalApiUsage[],
3232
modeledMethods: Record<string, ModeledMethod>,
3333
) => void;
34-
onStopGenerateFromLlmClick: (dependencyName: string) => void;
34+
onStopGenerateFromLlmClick: (packageName: string) => void;
3535
onGenerateFromSourceClick: () => void;
3636
onModelDependencyClick: () => void;
3737
};

0 commit comments

Comments
 (0)