Skip to content

Commit 5d71ce4

Browse files
author
Dave Bartolomeo
committed
DEFAULT_USER_SETTINGS
1 parent 76354c4 commit 5d71ce4

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

extensions/ql-vscode/src/common/interface-types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,10 @@ export interface UserSettings {
152152
shouldShowProvenance: boolean;
153153
}
154154

155+
export const DEFAULT_USER_SETTINGS: UserSettings = {
156+
shouldShowProvenance: false,
157+
};
158+
155159
/** Message indicating that the user's configuration settings have changed. */
156160
interface SetUserSettingsMsg {
157161
t: "setUserSettings";

extensions/ql-vscode/src/view/compare/Compare.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import type {
77
SetComparisonQueryInfoMessage,
88
UserSettings,
99
} from "../../common/interface-types";
10+
import { DEFAULT_USER_SETTINGS } from "../../common/interface-types";
1011
import CompareSelector from "./CompareSelector";
1112
import { vscode } from "../vscode-api";
1213
import CompareTable from "./CompareTable";
@@ -32,9 +33,9 @@ export function Compare(_: Record<string, never>): React.JSX.Element {
3233
const [comparison, setComparison] = useState<SetComparisonsMessage | null>(
3334
null,
3435
);
35-
const [userSettings, setUserSettings] = useState<UserSettings>({
36-
shouldShowProvenance: false,
37-
});
36+
const [userSettings, setUserSettings] = useState<UserSettings>(
37+
DEFAULT_USER_SETTINGS,
38+
);
3839

3940
const message = comparison?.message || "Empty comparison";
4041
const hasRows =

extensions/ql-vscode/src/view/results/ResultsApp.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import type {
1313
} from "../../common/interface-types";
1414
import {
1515
ALERTS_TABLE_NAME,
16+
DEFAULT_USER_SETTINGS,
1617
GRAPH_TABLE_NAME,
1718
} from "../../common/interface-types";
1819
import { ResultTables } from "./ResultTables";
@@ -78,9 +79,9 @@ export function ResultsApp() {
7879
isExpectingResultsUpdate: true,
7980
});
8081

81-
const [userSettings, setUserSettings] = useState<UserSettings>({
82-
shouldShowProvenance: false,
83-
});
82+
const [userSettings, setUserSettings] = useState<UserSettings>(
83+
DEFAULT_USER_SETTINGS,
84+
);
8485

8586
const updateStateWithNewResultsInfo = useCallback(
8687
(resultsInfo: ResultsInfo): void => {

0 commit comments

Comments
 (0)