Skip to content

Commit 6304fe0

Browse files
authored
Update typings for mocha (#752)
* Update typings for mocha This is includes an update of the lock file to the v2 format. It's a big change, but not much is happening here. I thought it best to keep it separate. * Fix globalSetup/teardown for mocha Updating the typings for mocha uncovered an error in how we were registering global setups and teardowns. When calling `mocha.globalSetup` or `mocha.globalTeardown`, any previously registered globals are overwritten. The workaround is to attach globals directly to the internal options object. This is a requirement because we are now registering globals in multiple files. Unfortunately, the typings for mocha do not permit this and I may need to fix them again.
1 parent be9084e commit 6304fe0

6 files changed

Lines changed: 12288 additions & 38 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ Here are a few things you can do that will increase the likelihood of your pull
2929

3030
## Setting up a local build
3131

32-
Make sure you have a fairly recent version of vscode (>1.32) and are using nodejs
33-
version >=v10.13.0. (Tested on v10.15.1 and v10.16.0).
32+
Make sure you have installed recent versions of vscode (>= v1.52), node (>=12.16), and npm (>= 7.5.2). Earlier versions will probably work, but we no longer test against them.
3433

3534
### Installing all packages
3635

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ To see what has changed in the last few versions of the extension, see the [Chan
1616
* Provides an easy way to run queries from the large, open source repository of [CodeQL security queries](https://github.com/github/codeql).
1717
* Adds IntelliSense to support you writing and editing your own CodeQL query and library files.
1818

19-
2019
## Project goals and scope
2120

2221
This project will track new feature development in CodeQL and, whenever appropriate, bring that functionality to the Visual Studio Code experience.

0 commit comments

Comments
 (0)