Check undefined instead of using typeof

robertbrignull · robertbrignull · commit 64531f5a6f0c · 2023-03-16T10:54:29.000Z
diff --git a/extensions/ql-vscode/src/pure/errors.ts b/extensions/ql-vscode/src/pure/errors.ts
@@ -79,7 +79,7 @@ export interface ErrorLike {
 function isErrorLike(error: any): error is ErrorLike {
   if (
     typeof error.message === "string" &&
-    (typeof error.stack === "undefined" || typeof error.stack === "string")
+    (error.stack === undefined || typeof error.stack === "string")
   ) {
     return true;
   }

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ export interface ErrorLike {`
`79`	`79`	`function isErrorLike(error: any): error is ErrorLike {`
`80`	`80`	`if (`
`81`	`81`	`typeof error.message === "string" &&`
`82`		`- (typeof error.stack === "undefined" \|\| typeof error.stack === "string")`
	`82`	`+ (error.stack === undefined \|\| typeof error.stack === "string")`
`83`	`83`	`) {`
`84`	`84`	`return true;`
`85`	`85`	`}`