Skip to content

Commit 6791ddb

Browse files
authored
Pass dependency name around when automodeling (#2681)
1 parent 6dc0b14 commit 6791ddb

File tree

6 files changed

+19
-3
lines changed

6 files changed

+19
-3
lines changed

extensions/ql-vscode/src/common/interface-types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,7 @@ interface GenerateExternalApiMessage {
549549

550550
interface GenerateExternalApiFromLlmMessage {
551551
t: "generateExternalApiFromLlm";
552+
dependencyName: string;
552553
externalApiUsages: ExternalApiUsage[];
553554
modeledMethods: Record<string, ModeledMethod>;
554555
}

extensions/ql-vscode/src/data-extensions-editor/auto-modeler.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,26 @@ export class AutoModeler {
2929
) {}
3030

3131
public async startModeling(
32+
dependency: string,
3233
externalApiUsages: ExternalApiUsage[],
3334
modeledMethods: Record<string, ModeledMethod>,
3435
mode: Mode,
3536
): Promise<void> {
36-
await this.modelDependency(externalApiUsages, modeledMethods, mode);
37+
await this.modelDependency(
38+
dependency,
39+
externalApiUsages,
40+
modeledMethods,
41+
mode,
42+
);
3743
}
3844

3945
private async modelDependency(
46+
dependency: string,
4047
externalApiUsages: ExternalApiUsage[],
4148
modeledMethods: Record<string, ModeledMethod>,
4249
mode: Mode,
4350
): Promise<void> {
51+
void extLogger.log(`Modeling dependency ${dependency}`);
4452
await withProgress(async (progress) => {
4553
const maxStep = 3000;
4654

extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
170170
case "generateExternalApiFromLlm":
171171
if (useLlmGenerationV2()) {
172172
await this.generateModeledMethodsFromLlmV2(
173+
msg.dependencyName,
173174
msg.externalApiUsages,
174175
msg.modeledMethods,
175176
);
@@ -459,10 +460,12 @@ export class DataExtensionsEditorView extends AbstractWebview<
459460
}
460461

461462
private async generateModeledMethodsFromLlmV2(
463+
dependency: string,
462464
externalApiUsages: ExternalApiUsage[],
463465
modeledMethods: Record<string, ModeledMethod>,
464466
): Promise<void> {
465467
await this.autoModeler.startModeling(
468+
dependency,
466469
externalApiUsages,
467470
modeledMethods,
468471
this.mode,

extensions/ql-vscode/src/view/data-extensions-editor/DataExtensionsEditor.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,13 @@ export function DataExtensionsEditor({
227227

228228
const onGenerateFromLlmClick = useCallback(
229229
(
230+
dependencyName: string,
230231
externalApiUsages: ExternalApiUsage[],
231232
modeledMethods: Record<string, ModeledMethod>,
232233
) => {
233234
vscode.postMessage({
234235
t: "generateExternalApiFromLlm",
236+
dependencyName,
235237
externalApiUsages,
236238
modeledMethods,
237239
});

extensions/ql-vscode/src/view/data-extensions-editor/LibraryRow.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ type Props = {
8585
modeledMethods: Record<string, ModeledMethod>,
8686
) => void;
8787
onGenerateFromLlmClick: (
88+
dependencyName: string,
8889
externalApiUsages: ExternalApiUsage[],
8990
modeledMethods: Record<string, ModeledMethod>,
9091
) => void;
@@ -119,11 +120,11 @@ export const LibraryRow = ({
119120

120121
const handleModelWithAI = useCallback(
121122
async (e: React.MouseEvent) => {
122-
onGenerateFromLlmClick(externalApiUsages, modeledMethods);
123+
onGenerateFromLlmClick(title, externalApiUsages, modeledMethods);
123124
e.stopPropagation();
124125
e.preventDefault();
125126
},
126-
[externalApiUsages, modeledMethods, onGenerateFromLlmClick],
127+
[title, externalApiUsages, modeledMethods, onGenerateFromLlmClick],
127128
);
128129

129130
const handleModelFromSource = useCallback(

extensions/ql-vscode/src/view/data-extensions-editor/ModeledMethodsList.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ type Props = {
2727
modeledMethods: Record<string, ModeledMethod>,
2828
) => void;
2929
onGenerateFromLlmClick: (
30+
dependencyName: string,
3031
externalApiUsages: ExternalApiUsage[],
3132
modeledMethods: Record<string, ModeledMethod>,
3233
) => void;

0 commit comments

Comments
 (0)