Skip to content

Commit 6a0cae5

Browse files
committed
Remove call type for unmodelable methods
This removes the call type as shown for an unmodelable method. We still need to decide how to show this information, so this may be added back in later.
1 parent 1efc276 commit 6a0cae5

File tree

1 file changed

+2
-17
lines changed
  • extensions/ql-vscode/src/view/data-extensions-editor

1 file changed

+2
-17
lines changed

extensions/ql-vscode/src/view/data-extensions-editor/MethodRow.tsx

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,6 @@ const modelTypeOptions: Array<{ value: ModeledMethodType; label: string }> = [
5757
{ value: "neutral", label: "Neutral" },
5858
];
5959

60-
const typeNames = modelTypeOptions.reduce(
61-
(acc, { value, label }) => {
62-
acc[value] = label;
63-
return acc;
64-
},
65-
{} as Record<ModeledMethodType, string>,
66-
);
67-
6860
type Props = {
6961
externalApiUsage: ExternalApiUsage;
7062
modeledMethod: ModeledMethod | undefined;
@@ -272,7 +264,7 @@ function ModelableMethodRow(props: Props) {
272264
}
273265

274266
function UnmodelableMethodRow(props: Props) {
275-
const { externalApiUsage, modeledMethod, mode } = props;
267+
const { externalApiUsage, mode } = props;
276268

277269
const jumpToUsage = useCallback(
278270
() => sendJumpToUsageMessage(externalApiUsage),
@@ -291,14 +283,7 @@ function UnmodelableMethodRow(props: Props) {
291283
)}
292284
<ViewLink onClick={jumpToUsage}>View</ViewLink>
293285
</ApiOrMethodCell>
294-
<VSCodeDataGridCell gridColumn={2}>
295-
{externalApiUsage.supported &&
296-
!modeledMethod &&
297-
externalApiUsage.supportedType !== "none" && (
298-
<>{typeNames[externalApiUsage.supportedType]}</>
299-
)}
300-
</VSCodeDataGridCell>
301-
<VSCodeDataGridCell gridColumn="span 3">
286+
<VSCodeDataGridCell gridColumn="span 4">
302287
Method modeled by CodeQL or a different extension pack
303288
</VSCodeDataGridCell>
304289
</VSCodeDataGridRow>

0 commit comments

Comments
 (0)