Skip to content

Commit 6de58ec

Browse files
committed
Address review comments
1 parent cbebeec commit 6de58ec

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

extensions/ql-vscode/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## [UNRELEASED]
44

55
- Restart the CodeQL language server whenever the _CodeQL: Restart Query Server_ command is invoked. This avoids bugs where the CLI version changes to support new language features, but the language server is not updated. [#2238](https://github.com/github/vscode-codeql/pull/2238)
6-
- Avoid requiring a manual restart of the query server when the [external CLI config file](https://docs.github.com/en/code-security/codeql-cli/using-the-codeql-cli/specifying-command-options-in-a-codeql-configuration-file#using-a-codeql-configuration-file) changes. [#22892289)
6+
- Avoid requiring a manual restart of the query server when the [external CLI config file](https://docs.github.com/en/code-security/codeql-cli/using-the-codeql-cli/specifying-command-options-in-a-codeql-configuration-file#using-a-codeql-configuration-file) changes. [#2289](https://github.com/github/vscode-codeql/pull/2289)
77

88
## 1.8.1 - 23 March 2023
99

extensions/ql-vscode/src/extension.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
workspace,
1414
} from "vscode";
1515
import { LanguageClient } from "vscode-languageclient/node";
16-
import { arch, platform } from "os";
16+
import { arch, platform, homedir } from "os";
1717
import { ensureDir } from "fs-extra";
1818
import { join } from "path";
1919
import { dirSync } from "tmp-promise";
@@ -1019,8 +1019,9 @@ async function activateWithInstalledDistribution(
10191019
* See https://docs.github.com/en/code-security/codeql-cli/using-the-codeql-cli/specifying-command-options-in-a-codeql-configuration-file#using-a-codeql-configuration-file
10201020
*/
10211021
function watchExternalConfigFile(app: ExtensionApp, ctx: ExtensionContext) {
1022-
if (process.env.HOME) {
1023-
const configPath = join(process.env.HOME, ".config/codeql", "config");
1022+
const home = homedir();
1023+
if (home) {
1024+
const configPath = join(home, ".config", "codeql", "config");
10241025
const configWatcher = watch(configPath, {
10251026
// These options avoid firing the event twice.
10261027
persistent: true,

0 commit comments

Comments
 (0)