Skip to content

Commit 6e50d4a

Browse files
committed
Address feedback.
1 parent f8a90e5 commit 6e50d4a

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

docs/test-plan.md

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,34 +145,40 @@ Run one of the above MRVAs, but cancel it from within VS Code:
145145

146146
### CodeQL Model Editor
147147

148-
Note: this is still behind feature flags.
148+
Note the tests here require the feature flag:
149+
- `codeQL.model.editor`
149150

150151
#### Test Case 1: Opening the model editor
151152

152-
1. Download the `dsp-testing/sql2o-example` database from GitHub.
153+
1. Download the `sofastack/sofa-jraft` java database from GitHub.
153154
2. Open the Model Editor with the "CodeQL: Open CodeQL Model Editor" command from the command palette.
154155
- Check that the editor loads and shows methods to model.
155-
- Check that methods are grouped per library.
156+
- Check that methods are grouped per library (e.g. `rocksdbjni@7.7.3` or `asm@6.0`)
156157
- Check that the "Open database" link works.
157-
- Check that the "Open extension pack" link works.
158158

159159
#### Test Case 2: Model methods
160160

161-
1. Expand one of the packages
161+
1. Expand one of the libraries.
162162
- Change the model type and check that the other dropdowns change.
163163
2. Save the modeled methods.
164-
- Check that the model `yml` file has the entries that was modeled.
164+
3. Click "Open extension pack"
165+
- Check that the file explorer opens a directory with a "models" directory
166+
4. Open the ".model.yml" file corresponding to the library that was changed.
167+
- Check that the file contrains the entries that was modeled.
165168

166169
#### Test Case 3: Model with AI
167170

171+
Note that this test requires the feature flag:
172+
- `codeQL.model.llmGeneration`
173+
168174
1. Click "Model with AI".
169175
- Check that rows change to "Thinking".
170176
- Check that results come back and rows get filled out.
171177

172178
#### Test Case 4: Model as dependency
173179

174180
1. Click "Model as dependency"
175-
- Check that grouping are now per package.
181+
- Check that grouping are now per package (e.g. `com.alipay.sofa.rraft.option` or `com.google.protobuf`)
176182
2. Click "Generate".
177183
- Check that rows are filled out.
178184

0 commit comments

Comments
 (0)