Rename + expand existing helper for shuffling lists

Author: robertbrignull

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/history-tree-data-provider.test.ts

@@ -17,7 +17,7 @@ import {
   createMockLocalQueryInfo,
   createMockQueryWithResults,
 } from "../../../factories/query-history/local-query-history-item";
-import { shuffleHistoryItems } from "../../utils/query-history-helpers";
+import { shuffle } from "../../utils/list-helpers";
 import { createMockVariantAnalysisHistoryItem } from "../../../factories/query-history/variant-analysis-history-item";
 import type { VariantAnalysisHistoryItem } from "../../../../src/query-history/variant-analysis-history-item";
 import { QueryStatus } from "../../../../src/query-history/query-status";
@@ -121,10 +121,7 @@ describe("HistoryTreeDataProvider", () => {
         variantAnalysisStatus: VariantAnalysisStatus.InProgress,
       }),
     ];
-    allHistory = shuffleHistoryItems([
-      ...localQueryHistory,
-      ...variantAnalysisHistory,
-    ]);
+    allHistory = shuffle([...localQueryHistory, ...variantAnalysisHistory]);
 
     labelProvider = new HistoryItemLabelProvider({
       format: "",

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/query-history-manager.test.ts

@@ -19,7 +19,7 @@ import {
   createMockLocalQueryInfo,
   createMockQueryWithResults,
 } from "../../../factories/query-history/local-query-history-item";
-import { shuffleHistoryItems } from "../../utils/query-history-helpers";
+import { shuffle } from "../../utils/list-helpers";
 import { createMockVariantAnalysisHistoryItem } from "../../../factories/query-history/variant-analysis-history-item";
 import type { VariantAnalysisHistoryItem } from "../../../../src/query-history/variant-analysis-history-item";
 import { QueryStatus } from "../../../../src/query-history/query-status";
@@ -138,10 +138,7 @@ describe("QueryHistoryManager", () => {
         variantAnalysisStatus: VariantAnalysisStatus.InProgress,
       }),
     ];
-    allHistory = shuffleHistoryItems([
-      ...localQueryHistory,
-      ...variantAnalysisHistory,
-    ]);
+    allHistory = shuffle([...localQueryHistory, ...variantAnalysisHistory]);
   });
 
   afterEach(async () => {

extensions/ql-vscode/test/vscode-tests/utils/list-helpers.ts

@@ -0,0 +1,3 @@
+export function shuffle<T>(xs: T[]): T[] {
+  return xs.sort(() => Math.random() - 0.5);
+}