Skip to content

Commit 70aa6df

Browse files
committed
Fail VSCE workflow on failure
We were ignoring errors coming from `vsce publish` and this was causing the workflow to succeed even when the publish failed. This will remove the `||` and let the workflow fail if the publish fails.
1 parent e6efac0 commit 70aa6df

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,7 @@ jobs:
164164

165165
- name: Publish to Registry
166166
run: |
167-
npx vsce publish -p $VSCE_TOKEN --packagePath *.vsix || \
168-
echo "Failed to publish to VS Code Marketplace. \
169-
If this was an authentication problem, please make sure the \
170-
auth token hasn't expired."
167+
npx vsce publish -p $VSCE_TOKEN --packagePath *.vsix
171168
172169
open-vsx-publish:
173170
name: Publish to Open VSX Registry

0 commit comments

Comments
 (0)