Skip to content

Commit 75540b4

Browse files
authored
Merge pull request #2884 from github/aeisenberg/avoid-double-restart
Avoid double restarts of the query server
2 parents 3489c26 + a9edb36 commit 75540b4

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

extensions/ql-vscode/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## [UNRELEASED]
44

5+
- Fix a bug where the query server was restarted twice after configuration changes. [#2884](https://github.com/github/vscode-codeql/pull/2884).
6+
57
## 1.9.1 - 29 September 2023
68

79
- Add warning when using a VS Code version older than 1.82.0. [#2854](https://github.com/github/vscode-codeql/pull/2854)

extensions/ql-vscode/src/query-server/server-process.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export class ServerProcess implements Disposable {
2626
this.connection.end();
2727
this.child.stdin!.end();
2828
this.child.stderr!.destroy();
29+
this.child.removeAllListeners();
2930
// TODO kill the process if it doesn't terminate after a certain time limit.
3031

3132
// On Windows, we usually have to terminate the process before closing its stdout.

0 commit comments

Comments
 (0)