Move viewAst to top level

Author: robertbrignull

extensions/ql-vscode/src/extension.ts

@@ -1459,29 +1459,21 @@ async function activateWithInstalledDistribution(
 
   ctx.subscriptions.push(astViewer);
 
-  async function viewAst(
-    progress: ProgressCallback,
-    token: CancellationToken,
-    selectedFile: Uri,
-  ): Promise<void> {
-    const ast = await printAstTemplateProvider.provideAst(
-      progress,
-      token,
-      selectedFile ?? window.activeTextEditor?.document.uri,
-    );
-    if (ast) {
-      astViewer.updateRoots(await ast.getRoots(), ast.db, ast.fileName);
-    }
-  }
-
   ctx.subscriptions.push(
     commandRunnerWithProgress(
       "codeQL.viewAst",
       async (
         progress: ProgressCallback,
         token: CancellationToken,
         selectedFile: Uri,
-      ) => await viewAst(progress, token, selectedFile),
+      ) =>
+        await viewAst(
+          astViewer,
+          printAstTemplateProvider,
+          progress,
+          token,
+          selectedFile,
+        ),
       {
         cancellable: true,
         title: "Calculate AST",
@@ -1497,7 +1489,14 @@ async function activateWithInstalledDistribution(
         progress: ProgressCallback,
         token: CancellationToken,
         selectedFile: Uri,
-      ) => await viewAst(progress, token, selectedFile),
+      ) =>
+        await viewAst(
+          astViewer,
+          printAstTemplateProvider,
+          progress,
+          token,
+          selectedFile,
+        ),
       {
         cancellable: true,
         title: "Calculate AST",
@@ -1513,7 +1512,14 @@ async function activateWithInstalledDistribution(
         progress: ProgressCallback,
         token: CancellationToken,
         selectedFile: Uri,
-      ) => await viewAst(progress, token, selectedFile),
+      ) =>
+        await viewAst(
+          astViewer,
+          printAstTemplateProvider,
+          progress,
+          token,
+          selectedFile,
+        ),
       {
         cancellable: true,
         title: "Calculate AST",
@@ -1898,6 +1904,23 @@ async function runVariantAnalysis(
   );
 }
 
+async function viewAst(
+  astViewer: AstViewer,
+  printAstTemplateProvider: TemplatePrintAstProvider,
+  progress: ProgressCallback,
+  token: CancellationToken,
+  selectedFile: Uri,
+): Promise<void> {
+  const ast = await printAstTemplateProvider.provideAst(
+    progress,
+    token,
+    selectedFile ?? window.activeTextEditor?.document.uri,
+  );
+  if (ast) {
+    astViewer.updateRoots(await ast.getRoots(), ast.db, ast.fileName);
+  }
+}
+
 function addUnhandledRejectionListener() {
   const handler = (error: unknown) => {
     // This listener will be triggered for errors from other extensions as