Skip to content

Commit 7777f9d

Browse files
committed
Retry tests more aggressively on windows
There are some flaky CI test failures that manifest only as a message like [main 2020-06-01T16:09:47.671Z] [VS Code]: render process crashed! (and only afaict on windows) which I am not sure how to detect at the moment. If that message is occurring in the exception caught at this stage, we can check for it.
1 parent 572e74e commit 7777f9d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

extensions/ql-vscode/src/vscode-tests/run-integration-tests.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as path from 'path';
2+
import * as os from 'os';
23
import { runTests } from 'vscode-test';
34

45
// A subset of the fields in TestOptions from vscode-test, which we
@@ -26,6 +27,11 @@ async function runTestsWithRetryOnSegfault(suite: Suite, tries: number): Promise
2627
if (t < tries - 1)
2728
console.error('Retrying...');
2829
}
30+
else if (os.platform() === 'win32') {
31+
console.error(`Test runner caught exception (${err})`);
32+
if (t < tries - 1)
33+
console.error('Retrying...');
34+
}
2935
else {
3036
throw err;
3137
}

0 commit comments

Comments
 (0)