Skip to content

Commit 77deea7

Browse files
committed
Rename: queryId -> historyItemId
1 parent 2eaa923 commit 77deea7

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

extensions/ql-vscode/src/query-history-info.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export function getQueryHistoryItemId(item: QueryHistoryInfo): string {
2525
case 'remote':
2626
return item.queryId;
2727
case 'variant-analysis':
28-
return item.queryId;
28+
return item.historyItemId;
2929
default:
3030
assertNever(item);
3131
}

extensions/ql-vscode/src/query-history.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ export class QueryHistoryManager extends DisposableObject {
604604
t: 'variant-analysis',
605605
status: QueryStatus.InProgress,
606606
completed: false,
607-
queryId: nanoid(),
607+
historyItemId: nanoid(),
608608
variantAnalysis,
609609
});
610610

extensions/ql-vscode/src/remote-queries/variant-analysis-history-item.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface VariantAnalysisHistoryItem {
1010
resultCount?: number;
1111
status: QueryStatus;
1212
completed: boolean;
13-
readonly queryId: string,
13+
readonly historyItemId: string,
1414
variantAnalysis: VariantAnalysis;
1515
userSpecifiedLabel?: string;
1616
}

extensions/ql-vscode/test/pure-tests/query-history-info.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('Query history info', () => {
3232
t: 'variant-analysis',
3333
status: QueryStatus.InProgress,
3434
completed: false,
35-
queryId: 'abc123',
35+
historyItemId: 'abc123',
3636
variantAnalysis: createMockVariantAnalysis()
3737
};
3838

@@ -42,7 +42,7 @@ describe('Query history info', () => {
4242
});
4343
});
4444

45-
describe('getQueryId', () => {
45+
describe('getQueryHistoryItemId', () => {
4646
it('should get the ID for local history items', () => {
4747
const date = new Date('2022-01-01T00:00:00.000Z');
4848
const dateStr = date.toLocaleString();
@@ -66,13 +66,13 @@ describe('Query history info', () => {
6666
t: 'variant-analysis',
6767
status: QueryStatus.InProgress,
6868
completed: false,
69-
queryId: 'abc123',
69+
historyItemId: 'abc123',
7070
variantAnalysis: createMockVariantAnalysis()
7171
};
7272

7373
const queryId = getQueryHistoryItemId(queryHistoryItem);
7474

75-
expect(queryId).to.equal(queryHistoryItem.queryId);
75+
expect(queryId).to.equal(queryHistoryItem.historyItemId);
7676
});
7777
});
7878
});

0 commit comments

Comments
 (0)