Merge pull request #1553 from github/koesie10/show-variant-analysis-view

Open variant analysis view after submission

Author: koesie10

extensions/ql-vscode/src/extension.ts

@@ -921,7 +921,15 @@ async function activateWithInstalledDistribution(
 
   ctx.subscriptions.push(
     commandRunner('codeQL.mockVariantAnalysisView', async () => {
-      const variantAnalysisView = new VariantAnalysisView(ctx);
+      const variantAnalysisView = new VariantAnalysisView(ctx, 1);
+      variantAnalysisView.openView();
+    })
+  );
+
+  // The "openVariantAnalysisView" command is internal-only.
+  ctx.subscriptions.push(
+    commandRunner('codeQL.openVariantAnalysisView', async (variantAnalysisId: number) => {
+      const variantAnalysisView = new VariantAnalysisView(ctx, variantAnalysisId);
       variantAnalysisView.openView();
     })
   );

extensions/ql-vscode/src/remote-queries/run-remote-query.ts

@@ -12,7 +12,7 @@ import {
   showAndLogInformationMessage,
   tryGetQueryMetadata,
   pluralize,
-  tmpDir
+  tmpDir,
 } from '../helpers';
 import { Credentials } from '../authentication';
 import * as cli from '../cli';
@@ -273,10 +273,11 @@ export async function runRemoteQuery(
 
       const processedVariantAnalysis = processVariantAnalysis(variantAnalysisSubmission, variantAnalysisResponse);
 
-      // TODO: Remove once we have a proper notification
-      void showAndLogInformationMessage('Variant analysis submitted for processing');
       void logger.log(`Variant analysis:\n${JSON.stringify(processedVariantAnalysis, null, 2)}`);
 
+      void showAndLogInformationMessage(`Variant analysis ${processedVariantAnalysis.query.name} submitted for processing`);
+
+      void commands.executeCommand('codeQL.openVariantAnalysisView', processedVariantAnalysis.id);
       void commands.executeCommand('codeQL.monitorVariantAnalysis', processedVariantAnalysis);
 
       return { variantAnalysis: processedVariantAnalysis };

extensions/ql-vscode/src/remote-queries/variant-analysis-view.ts

@@ -1,17 +1,24 @@
-import { ViewColumn } from 'vscode';
+import { ExtensionContext, ViewColumn } from 'vscode';
 import { AbstractWebview, WebviewPanelConfig } from '../abstract-webview';
 import { WebviewMessage } from '../interface-utils';
 import { logger } from '../logging';
 
 export class VariantAnalysisView extends AbstractWebview<WebviewMessage, WebviewMessage> {
+  public constructor(
+    ctx: ExtensionContext,
+    private readonly variantAnalysisId: number,
+  ) {
+    super(ctx);
+  }
+
   public openView() {
     this.getPanel().reveal(undefined, true);
   }
 
   protected getPanelConfig(): WebviewPanelConfig {
     return {
       viewId: 'variantAnalysisView',
-      title: 'CodeQL Query Results',
+      title: `CodeQL Query Results for ${this.variantAnalysisId}`,
       viewColumn: ViewColumn.Active,
       preserveFocus: true,
       view: 'variant-analysis'