Skip to content

Commit 7b1a93d

Browse files
committed
Use HorizontalSpace instead of margin-left
1 parent d3ea84e commit 7b1a93d

2 files changed

Lines changed: 7 additions & 14 deletions

File tree

extensions/ql-vscode/src/view/common/icon/Codicon.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ type Props = {
88
className?: string;
99
};
1010

11-
export const CodiconIcon = styled.span`
11+
const CodiconIcon = styled.span`
1212
vertical-align: text-bottom;
1313
`;
1414

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
11
import * as React from 'react';
2-
import styled from 'styled-components';
32
import { VariantAnalysisStatus } from '../../remote-queries/shared/variant-analysis';
43
import { formatDecimal } from '../../pure/number';
5-
import { CodiconIcon, ErrorIcon, SuccessIcon, WarningIcon } from '../common';
6-
7-
const Container = styled.div`
8-
${CodiconIcon} {
9-
margin-left: 0.3em;
10-
}
11-
`;
4+
import { ErrorIcon, HorizontalSpace, SuccessIcon, WarningIcon } from '../common';
125

136
type Props = {
147
variantAnalysisStatus: VariantAnalysisStatus;
@@ -28,17 +21,17 @@ export const VariantAnalysisRepositoriesStats = ({
2821
if (variantAnalysisStatus === VariantAnalysisStatus.Failed) {
2922
return (
3023
<>
31-
0<ErrorIcon />
24+
0<HorizontalSpace size={2} /><ErrorIcon />
3225
</>
3326
);
3427
}
3528

3629
return (
37-
<Container>
30+
<>
3831
{formatDecimal(completedRepositoryCount)}/{formatDecimal(totalRepositoryCount)}
39-
{queryResult && <WarningIcon />}
32+
{queryResult && <><HorizontalSpace size={2} /><WarningIcon /></>}
4033
{!queryResult && variantAnalysisStatus === VariantAnalysisStatus.Succeeded &&
41-
<SuccessIcon label="Completed" />}
42-
</Container>
34+
<><HorizontalSpace size={2} /><SuccessIcon label="Completed" /></>}
35+
</>
4336
);
4437
};

0 commit comments

Comments
 (0)