Merge pull request #1963 from github/koesie10/webpack-production-build

Use Webpack in production mode for releases

Author: koesie10

.github/workflows/release.yml

@@ -59,6 +59,12 @@ jobs:
           name: vscode-codeql-extension
           path: artifacts
 
+      - name: Upload source maps
+        uses: actions/upload-artifact@v3
+        with:
+          name: vscode-codeql-sourcemaps
+          path: dist/vscode-codeql/out/*.map
+
         # TODO Run tests, or check that a test run on the same branch succeeded.
 
       - name: Create release

extensions/ql-vscode/gulpfile.ts/deploy.ts

@@ -8,6 +8,7 @@ import {
   writeFile,
 } from "fs-extra";
 import { resolve, join } from "path";
+import { isDevBuild } from "./dev";
 
 export interface DeployedPackage {
   distPath: string;
@@ -53,8 +54,6 @@ export async function deployPackage(
       await readFile(packageJsonPath, "utf8"),
     );
 
-    // Default to development build; use flag --release to indicate release build.
-    const isDevBuild = !process.argv.includes("--release");
     const distDir = join(__dirname, "../../../dist");
     await mkdirs(distDir);
 

extensions/ql-vscode/gulpfile.ts/dev.ts

@@ -0,0 +1,2 @@
+// Default to development build; use flag --release to indicate release build.
+export const isDevBuild = !process.argv.includes("--release");

extensions/ql-vscode/gulpfile.ts/webpack.config.ts

@@ -1,17 +1,18 @@
 import { resolve } from "path";
 import * as webpack from "webpack";
 import MiniCssExtractPlugin from "mini-css-extract-plugin";
+import { isDevBuild } from "./dev";
 
 export const config: webpack.Configuration = {
-  mode: "development",
+  mode: isDevBuild ? "development" : "production",
   entry: {
     webview: "./src/view/webview.tsx",
   },
   output: {
     path: resolve(__dirname, "..", "out"),
     filename: "[name].js",
   },
-  devtool: "inline-source-map",
+  devtool: isDevBuild ? "inline-source-map" : "source-map",
   resolve: {
     extensions: [".js", ".ts", ".tsx", ".json"],
     fallback: {
@@ -53,6 +54,9 @@ export const config: webpack.Configuration = {
           MiniCssExtractPlugin.loader,
           {
             loader: "css-loader",
+            options: {
+              sourceMap: true,
+            },
           },
         ],
       },