Skip to content

Commit 7baf11f

Browse files
committed
Split the data extensions editor domain models file
1 parent 73bd6d6 commit 7baf11f

File tree

4 files changed

+18
-20
lines changed

4 files changed

+18
-20
lines changed

extensions/ql-vscode/src/data-extensions-editor/interface.ts renamed to extensions/ql-vscode/src/data-extensions-editor/external-api-usage.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,3 @@ export type ExternalApiUsage = {
1414
supported: boolean;
1515
usages: Call[];
1616
};
17-
18-
export type ModeledMethodType =
19-
| "none"
20-
| "source"
21-
| "sink"
22-
| "summary"
23-
| "neutral";
24-
25-
export type ModeledMethod = {
26-
type: ModeledMethodType;
27-
input: string;
28-
output: string;
29-
kind: string;
30-
};
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
export type ModeledMethodType =
2+
| "none"
3+
| "source"
4+
| "sink"
5+
| "summary"
6+
| "neutral";
7+
8+
export type ModeledMethod = {
9+
type: ModeledMethodType;
10+
input: string;
11+
output: string;
12+
kind: string;
13+
};

extensions/ql-vscode/src/view/data-extensions-editor/DataExtensionsEditor.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import styled from "styled-components";
1414
import {
1515
Call,
1616
ExternalApiUsage,
17-
ModeledMethod,
18-
} from "../../data-extensions-editor/interface";
17+
} from "../../data-extensions-editor/external-api-usage";
18+
import { ModeledMethod } from "../../data-extensions-editor/modeled-method";
1919
import { MethodRow } from "./MethodRow";
2020
import { assertNever } from "../../pure/helpers-pure";
2121

extensions/ql-vscode/src/view/data-extensions-editor/MethodRow.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
import {
2-
ExternalApiUsage,
3-
ModeledMethod,
4-
} from "../../data-extensions-editor/interface";
51
import {
62
VSCodeDataGridCell,
73
VSCodeDataGridRow,
@@ -13,6 +9,9 @@ import * as React from "react";
139
import { useCallback, useMemo } from "react";
1410
import styled from "styled-components";
1511

12+
import { ExternalApiUsage } from "../../data-extensions-editor/external-api-usage";
13+
import { ModeledMethod } from "../../data-extensions-editor/modeled-method";
14+
1615
const Dropdown = styled(VSCodeDropdown)`
1716
width: 100%;
1817
`;

0 commit comments

Comments
 (0)