Skip to content

Commit 7ce0e0a

Browse files
committed
Rename supported to modelled.
1 parent 1367d38 commit 7ce0e0a

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

extensions/ql-vscode/src/view/data-extensions-editor/DataExtensionsEditor.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { ModeledMethod } from "../../data-extensions-editor/modeled-method";
1616
import { MethodRow } from "./MethodRow";
1717
import { assertNever } from "../../pure/helpers-pure";
1818
import { vscode } from "../vscode-api";
19-
import { calculateSupportedPercentage } from "./supported";
19+
import { calculateModelledPercentage } from "./modelled";
2020

2121
export const DataExtensionsEditorContainer = styled.div`
2222
margin-top: 1rem;
@@ -97,12 +97,12 @@ export function DataExtensionsEditor({
9797
};
9898
}, []);
9999

100-
const supportedPercentage = useMemo(
101-
() => calculateSupportedPercentage(externalApiUsages),
100+
const modelledPercentage = useMemo(
101+
() => calculateModelledPercentage(externalApiUsages),
102102
[externalApiUsages],
103103
);
104104

105-
const unsupportedPercentage = 100 - supportedPercentage;
105+
const unModelledPercentage = 100 - modelledPercentage;
106106

107107
const onChange = useCallback(
108108
(method: ExternalApiUsage, model: ModeledMethod) => {
@@ -140,10 +140,10 @@ export function DataExtensionsEditor({
140140
{externalApiUsages.length > 0 && (
141141
<>
142142
<div>
143-
<h3>External API support stats</h3>
143+
<h3>External API model stats</h3>
144144
<ul>
145-
<li>Supported: {supportedPercentage.toFixed(2)}%</li>
146-
<li>Unsupported: {unsupportedPercentage.toFixed(2)}%</li>
145+
<li>Modelled: {modelledPercentage.toFixed(2)}%</li>
146+
<li>Unmodelled: {unModelledPercentage.toFixed(2)}%</li>
147147
</ul>
148148
</div>
149149
<div>

extensions/ql-vscode/src/view/data-extensions-editor/__tests__/supported.spec.ts renamed to extensions/ql-vscode/src/view/data-extensions-editor/__tests__/modelled.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,33 @@
1-
import { calculateSupportedPercentage } from "../supported";
1+
import { calculateModelledPercentage } from "../modelled";
22

3-
describe("calculateSupportedPercentage", () => {
3+
describe("calculateModelledPercentage", () => {
44
it("when there are no external API usages", () => {
5-
expect(calculateSupportedPercentage([])).toBe(0);
5+
expect(calculateModelledPercentage([])).toBe(0);
66
});
77

8-
it("when there are is 1 supported external API usage", () => {
8+
it("when there are is 1 modelled external API usage", () => {
99
expect(
10-
calculateSupportedPercentage([
10+
calculateModelledPercentage([
1111
{
1212
supported: true,
1313
},
1414
]),
1515
).toBe(100);
1616
});
1717

18-
it("when there are is 1 unsupported external API usage", () => {
18+
it("when there are is 1 unmodelled external API usage", () => {
1919
expect(
20-
calculateSupportedPercentage([
20+
calculateModelledPercentage([
2121
{
2222
supported: false,
2323
},
2424
]),
2525
).toBe(0);
2626
});
2727

28-
it("when there are multiple supporte and unsupported external API usage", () => {
28+
it("when there are multiple modelled and unmodelled external API usage", () => {
2929
expect(
30-
calculateSupportedPercentage([
30+
calculateModelledPercentage([
3131
{
3232
supported: false,
3333
},

extensions/ql-vscode/src/view/data-extensions-editor/supported.ts renamed to extensions/ql-vscode/src/view/data-extensions-editor/modelled.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import { ExternalApiUsage } from "../../data-extensions-editor/external-api-usage";
22

3-
export function calculateSupportedPercentage(
3+
export function calculateModelledPercentage(
44
externalApiUsages: Array<Pick<ExternalApiUsage, "supported">>,
55
): number {
66
if (externalApiUsages.length === 0) {
77
return 0;
88
}
99

10-
const supportedExternalApiUsages = externalApiUsages.filter(
10+
const modelledExternalApiUsages = externalApiUsages.filter(
1111
(m) => m.supported,
1212
);
1313

14-
const supportedRatio =
15-
supportedExternalApiUsages.length / externalApiUsages.length;
16-
return supportedRatio * 100;
14+
const modelledRatio =
15+
modelledExternalApiUsages.length / externalApiUsages.length;
16+
return modelledRatio * 100;
1717
}

0 commit comments

Comments
 (0)